From: Florian Weimer <fweimer@redhat.com>
To: Fangrui Song <maskray@google.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3 2/2] Default to --with-default-link=no (bug 25812)
Date: Fri, 29 Apr 2022 16:55:37 +0200 [thread overview]
Message-ID: <875yms0wie.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220429074349.gna53j7ujgqql4ux@google.com> (Fangrui Song's message of "Fri, 29 Apr 2022 00:43:49 -0700")
* Fangrui Song:
> On 2022-04-29, Florian Weimer wrote:
>>* Fangrui Song:
>>
>>>>How does lld place sections without a linker script? Purely based on
>>>>names?
>>>
>>> It entirely uses code to describe the built-in rules like gold, while
>>> GNU ld uses an internal linker script plus built-in code.
>>> (some rules cannot be described by the linker script language and needs
>>> code anyway).
>>
>>How can we make sure that certain sections are covered by RELRO, and
>>still get start/stop symbols for them?
>
> About __start_/__stop_:
> __start_/__stop_ symbols are special. They don't need to be mentioned in a
> linker script to take effects for lld and modern GNU ld. I haven't checked
> whether there is an ancient GNU ld which requires symbol assignments when the
> output section description is specified.
According to the BFD ld documentation, __start_/__stop_ symbols are only
generated if the resulting name is a C identifier and the name is the
same. That means that if we name the section .data.rel.ro.vtables or
something like that (to benefit from .data.rel.ro.* placement), we won't
get the start/stop symbols. If we use a C identifier name for the
section, it won't be covered by RELRO.
> About RELRO:
> It seems that there is no section name convention to make a section
> RELRO. Having a SECTIONS command with DATA_SEGMENT_ALIGN /
> DATA_SEGMENT_RELRO_END can specify all RELRO sections. I do not know a
> simpler approach than postprocessing ld.bfd --verbose output.
>
> To make GNU ld work, the following linker script is sufficient:
>
> SECTIONS {
> __libc_subfreeres : { *(__libc_subfreeres) }
> __libc_atexit : { *(__libc_atexit) }
> __libc_IO_vtables : { *(__libc_IO_vtables) }
> } INSERT BEFORE .data.rel.ro;
That might work. But if we cut down the number of vtables, I think we
can eliminate those special RELRO sections altogether.
We have been slowly migrating off __libc_subfreeres and the like because
having shutdown order depend on link is very non-obvious and
problematic. For example, for optimimum results, we want to shut down
malloc last on a thread.
Thanks,
Florian
next prev parent reply other threads:[~2022-04-29 14:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 15:32 [PATCH v3 1/2] scripts: Add glibcelf.py module Florian Weimer
2022-04-11 15:32 ` [PATCH v3 2/2] Default to --with-default-link=no (bug 25812) Florian Weimer
2022-04-22 6:12 ` Siddhesh Poyarekar
2022-04-22 6:35 ` Florian Weimer
2022-04-22 8:12 ` Siddhesh Poyarekar
2022-04-22 8:24 ` Florian Weimer
2022-04-22 8:32 ` Siddhesh Poyarekar
2022-04-22 8:34 ` Florian Weimer
2022-04-22 8:36 ` Siddhesh Poyarekar
2022-04-22 8:56 ` Andreas Schwab
2022-04-29 16:02 ` Dmitry V. Levin
2022-04-29 16:14 ` Florian Weimer
2022-04-29 20:48 ` Dmitry V. Levin
2022-04-28 7:25 ` Fangrui Song
2022-04-28 8:40 ` Florian Weimer
2022-04-29 6:00 ` Fangrui Song
2022-04-29 7:09 ` Florian Weimer
2022-04-29 7:43 ` Fangrui Song
2022-04-29 14:55 ` Florian Weimer [this message]
2022-04-29 19:26 ` Fangrui Song
2022-04-29 12:59 ` Adhemerval Zanella
2022-04-29 13:17 ` Florian Weimer
2022-04-29 13:55 ` Adhemerval Zanella
2022-04-29 14:03 ` Florian Weimer
2022-04-21 15:54 ` [PATCH v3 1/2] scripts: Add glibcelf.py module Siddhesh Poyarekar
2022-04-21 20:23 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yms0wie.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).