Re: [PATCH v3 3/3] aarch64: Enhanced CPU diagnostics for ld.so

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella Netto:

> On 05/04/24 07:16, Florian Weimer wrote:
>> This prints some information from struct cpu_features, and the midr_el1
>> and dczid_el0 system register contents on every CPU.
>> ---
>>  manual/dynlink.texi                  | 34 +++++++++++
>>  sysdeps/aarch64/dl-diagnostics-cpu.c | 84 ++++++++++++++++++++++++++++
>>  2 files changed, 118 insertions(+)
>>  create mode 100644 sysdeps/aarch64/dl-diagnostics-cpu.c
>> 
>> diff --git a/manual/dynlink.texi b/manual/dynlink.texi
>> index f2f2341818..6f4acf321d 100644
>> --- a/manual/dynlink.texi
>> +++ b/manual/dynlink.texi
>> @@ -224,6 +224,40 @@ reflect adjustment by @theglibc{}.
>>  These Linux-specific items show the values of @code{struct utsname}, as
>>  reported by the @code{uname} function.  @xref{Platform Type}.
>>  
>> +@item aarch64.cpu_features.@dots{}
>> +These items are specific to the AArch64 architectures.  They report data
>> +that is used by @theglibc{} to select alternative function
>> +implementations.
>
> Maybe also add some options are security related and not really tied
> to ifunc support (mte, bti).

I think MTE is also about selecting an implementation variant.  I will
add something regarding BTI.

>> diff --git a/sysdeps/aarch64/dl-diagnostics-cpu.c b/sysdeps/aarch64/dl-diagnostics-cpu.c
>> new file mode 100644
>> index 0000000000..e037e6ea8c
>> --- /dev/null
>> +++ b/sysdeps/aarch64/dl-diagnostics-cpu.c
>> @@ -0,0 +1,84 @@
>> +/* Print CPU diagnostics data in ld.so.  AArch64 version.
>> +   Copyright (C) 2021-2024 Free Software Foundation, Inc.
>
> Maybe just 2024 here.

I started with a copy of the x86 file.

Thanks,
Florian