public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3 3/3] aarch64: Enhanced CPU diagnostics for ld.so
Date: Fri, 05 Apr 2024 16:54:12 +0200	[thread overview]
Message-ID: <87le5r273f.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ZhAPjwQRW8s49QWD@arm.com> (Szabolcs Nagy's message of "Fri, 5 Apr 2024 15:49:51 +0100")

* Szabolcs Nagy:

> The 04/05/2024 12:16, Florian Weimer wrote:
>> This prints some information from struct cpu_features, and the midr_el1
>> and dczid_el0 system register contents on every CPU.
>
> thanks.
>
> i think we already rely on zva size to be the same across all cores
> (in memset) and i don't think linux allows different dczid_el0 per
> core (even if somebody built such a system).
>
> so i don't think that is needed.

Well … we've seen per-core feature sets change on some cores after
suspend/resume (although not on aarch64).  That's why we have t he
per-CPU iterator in the first place.

> i wonder if we should place a comment in init-arch.h to update
> _dl_diagnostics_cpu in case ifunc rules change as this seems
> easy to forget

I'll add a comment.

Thanks,
Florian


  reply	other threads:[~2024-04-05 14:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 10:16 [PATCH v3 0/3] " Florian Weimer
2024-04-05 10:16 ` [PATCH v3 1/3] elf: Add CPU iteration support for future use in ld.so diagnostics Florian Weimer
2024-04-05 12:57   ` H.J. Lu
2024-04-05 10:16 ` [PATCH v3 2/3] x86: Add generic CPUID data dumper to ld.so --list-diagnostics Florian Weimer
2024-04-05 12:57   ` H.J. Lu
2024-04-05 10:16 ` [PATCH v3 3/3] aarch64: Enhanced CPU diagnostics for ld.so Florian Weimer
2024-04-05 13:42   ` Adhemerval Zanella Netto
2024-04-08  8:38     ` Florian Weimer
2024-04-05 14:49   ` Szabolcs Nagy
2024-04-05 14:54     ` Florian Weimer [this message]
2024-04-08  7:36       ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le5r273f.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).