public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Bruno Haible <bruno@clisp.org>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] Fix special case for C2x strtol binary constant handling (BZ# 30371)
Date: Thu, 25 May 2023 13:33:42 +0200	[thread overview]
Message-ID: <877cswlk6h.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230525112032.4041628-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 25 May 2023 08:20:32 -0300")

* Adhemerval Zanella via Libc-alpha:

> diff --git a/stdlib/tst-strtol-binary-main.c b/stdlib/tst-strtol-binary-main.c
> index ece3100298..54cda5cd03 100644
> --- a/stdlib/tst-strtol-binary-main.c
> +++ b/stdlib/tst-strtol-binary-main.c

> +#define CHECK_RES(ARG, RES, EP, EXPECTED, EXPECTED_EP)			\
>    do									\
>      {									\
>        if (TEST_C2X)							\
>  	{								\
>  	  TEST_COMPARE ((RES), EXPECTED);				\
> -	  TEST_COMPARE (*(EP), 0);					\
> +	  TEST_VERIFY ((EP) == EXPECTED_EP);				\
>  	}								\
>        else								\
>  	{								\

You could add TEST_COMPARE_STRING (EP, EXPECTED_EP); as a debugging aid.
Patch looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2023-05-25 11:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 11:20 Adhemerval Zanella
2023-05-25 11:33 ` Florian Weimer [this message]
2023-05-25 12:22   ` Adhemerval Zanella Netto
2023-05-25 13:24 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cswlk6h.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=bruno@clisp.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).