From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Bruno Haible <bruno@clisp.org>
Subject: Re: [PATCH] Fix special case for C2x strtol binary constant handling (BZ# 30371)
Date: Thu, 25 May 2023 09:22:09 -0300 [thread overview]
Message-ID: <88a13c4e-ae3a-151d-e451-19bccc3ab562@linaro.org> (raw)
In-Reply-To: <877cswlk6h.fsf@oldenburg.str.redhat.com>
On 25/05/23 08:33, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> diff --git a/stdlib/tst-strtol-binary-main.c b/stdlib/tst-strtol-binary-main.c
>> index ece3100298..54cda5cd03 100644
>> --- a/stdlib/tst-strtol-binary-main.c
>> +++ b/stdlib/tst-strtol-binary-main.c
>
>> +#define CHECK_RES(ARG, RES, EP, EXPECTED, EXPECTED_EP) \
>> do \
>> { \
>> if (TEST_C2X) \
>> { \
>> TEST_COMPARE ((RES), EXPECTED); \
>> - TEST_COMPARE (*(EP), 0); \
>> + TEST_VERIFY ((EP) == EXPECTED_EP); \
>> } \
>> else \
>> { \
>
> You could add TEST_COMPARE_STRING (EP, EXPECTED_EP); as a debugging aid.
> Patch looks okay.
I though about it, but since the interface explicit state the the result
should point to the string itself I don't think it adds much.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks.
next prev parent reply other threads:[~2023-05-25 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 11:20 Adhemerval Zanella
2023-05-25 11:33 ` Florian Weimer
2023-05-25 12:22 ` Adhemerval Zanella Netto [this message]
2023-05-25 13:24 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a13c4e-ae3a-151d-e451-19bccc3ab562@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bruno@clisp.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).