public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Cc: DJ Delorie <dj@redhat.com>
Subject: Re: [patch v3] aligned_alloc: conform to C17
Date: Tue, 21 Mar 2023 18:28:29 +0100	[thread overview]
Message-ID: <877cvaf1z6.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <xn1qli1zia.fsf@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Tue, 21 Mar 2023 00:47:57 -0400")

* DJ Delorie via Libc-alpha:

> +/* For ISO C11.  */
> +static void *
> +__libc_aligned_alloc (size_t alignment, size_t bytes)
> +{

> +weak_alias (__libc_aligned_alloc, aligned_alloc)

I'm surprised that this even compiles.  This sort of makes the
function static and gives it external linkage.

Is anything calling __libc_aligned_alloc?

Perhaps you could use this?

  static void *
  weak_function
  aligned_alloc (size_t alignment, size_t bytes)
  {

Assuming that there are no internal callers.

  reply	other threads:[~2023-03-21 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21  4:47 DJ Delorie
2023-03-21 17:28 ` Florian Weimer [this message]
2023-03-21 17:47   ` DJ Delorie
2023-03-21 19:08     ` Florian Weimer
2023-03-21 20:21   ` DJ Delorie
2023-03-21 20:43     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cvaf1z6.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).