From: Florian Weimer <fw@deneb.enyo.de>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [patch v3] aligned_alloc: conform to C17
Date: Tue, 21 Mar 2023 21:43:23 +0100 [thread overview]
Message-ID: <87o7ol3kes.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <xnsfdxzwh5.fsf@greed.delorie.com> (DJ Delorie's message of "Tue, 21 Mar 2023 16:21:42 -0400")
* DJ Delorie:
> Florian Weimer <fw@deneb.enyo.de> writes:
>> Perhaps you could use this?
>
> One other difference that isn't obvious in the patch...
>
> the weak alias for aligned_alloc is inside a conditional:
>
> #if IS_IN (libc)
> . . .
> weak_alias (__libc_aligned_alloc, aligned_alloc)
> . . .
> #endif
>
> I don't know what, if anything uses malloc.c without being in glibc, but
> if such a thing existed, it would break if aligned_alloc weren't inside
> this conditional.
>
> Or the conditional could be removed?
Siddhesh added it for libc_malloc_debug, it has !IS_IN (libc).
Surely we want libc_malloc_debug to keep defining aligned_alloc,
so this shouldn't be conditional on IS_IN (libc).
prev parent reply other threads:[~2023-03-21 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 4:47 DJ Delorie
2023-03-21 17:28 ` Florian Weimer
2023-03-21 17:47 ` DJ Delorie
2023-03-21 19:08 ` Florian Weimer
2023-03-21 20:21 ` DJ Delorie
2023-03-21 20:43 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ol3kes.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).