public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>,
	 Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] libio: Update number of written bytes in dprintf implementation
Date: Tue, 31 Jan 2023 11:35:06 +0100	[thread overview]
Message-ID: <877cx3vvol.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvmcz6vyqsr.fsf@suse.de> (Andreas Schwab's message of "Tue, 31 Jan 2023 10:52:20 +0100")

* Andreas Schwab:

> On Jan 31 2023, Florian Weimer via Libc-alpha wrote:
>
>> The __printf_buffer_flush_dprintf function needs to record that
>> the buffer has been written before reusing it.  Without this
>> accounting, dprintf always returns zero.
>>
>> Fixes commit 8ece45e4f586abd212d1c02d74d38ef681a45600
>> ("libio: Convert __vdprintf_internal to buffers.
>                                                  ")

Thanks, fixed locally:

    libio: Update number of written bytes in dprintf implementation
    
    The __printf_buffer_flush_dprintf function needs to record that
    the buffer has been written before reusing it.  Without this
    accounting, dprintf always returns zero.
    
    Fixes commit 8ece45e4f586abd212d1c02d74d38ef681a45600
    ("libio: Convert __vdprintf_internal to buffers").

Florian


  reply	other threads:[~2023-01-31 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  9:38 Florian Weimer
2023-01-31  9:52 ` Andreas Schwab
2023-01-31 10:35   ` Florian Weimer [this message]
2023-01-31 21:07 ` Carlos O'Donell
2023-01-31 21:22   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cx3vvol.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).