From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] Use '%z' instead of '%Z' on printf functions
Date: Thu, 22 Sep 2022 12:44:18 +0200 [thread overview]
Message-ID: <877d1vofi5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220901130230.1684206-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 1 Sep 2022 10:02:30 -0300")
* Adhemerval Zanella via Libc-alpha:
> The Z modifier is a nonstandard synonymn for z (that predates z
> itself) and compiler might issue an warning for in invalid
> conversion specifier.
> ---
> catgets/gencat.c | 6 +++---
> elf/dl-load.c | 2 +-
> elf/dl-printf.c | 2 +-
> elf/dl-tunables.c | 2 +-
> elf/rtld.c | 6 +++---
> elf/sprof.c | 12 ++++++------
> elf/tst-dlmodcount.c | 2 +-
> elf/tst-tls-dlinfo.c | 2 +-
> gmon/tst-sprofil.c | 2 +-
> iconv/iconv_charmap.c | 2 +-
> libio/tst-ext.c | 8 ++++----
> libio/tst-widetext.c | 10 +++++-----
> libio/tst_swprintf.c | 6 +++---
> libio/tst_swscanf.c | 4 ++--
> locale/programs/ld-collate.c | 8 ++++----
> locale/programs/ld-ctype.c | 4 ++--
> localedata/bug-iconv-trans.c | 4 ++--
> localedata/tst-iconv-math-trans.c | 4 ++--
> math/test-tgmath-ret.c | 2 +-
> nptl/tst-rwlock6.c | 12 ++++++------
> nptl/tst-rwlock7.c | 16 ++++++++--------
> posix/runptests.c | 2 +-
> posix/wordexp-test.c | 4 ++--
> rt/tst-aio.c | 2 +-
> rt/tst-aio64.c | 2 +-
> string/tester.c | 2 +-
> string/tst-strlen.c | 4 ++--
> time/tst-strftime.c | 6 +++---
> wcsmbs/wcsmbs-tst1.c | 2 +-
> 29 files changed, 70 insertions(+), 70 deletions(-)
This looks okay to me. I reviewed the changes and built this on i686
and x86-64.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2022-09-22 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:02 Adhemerval Zanella
2022-09-22 10:44 ` Florian Weimer [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 18:14 Adhemerval Zanella
2022-08-31 19:34 ` Joseph Myers
2022-09-01 13:00 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d1vofi5.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).