public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH v3 2/2] aarch64: Move ld.so _start to separate file and drop _dl_skip_args
Date: Tue, 03 May 2022 13:53:04 +0200	[thread overview]
Message-ID: <877d72x273.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <6ff5facd3d1dedce53da3df77d025d2f0b6cc31b.1649854695.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Wed, 13 Apr 2022 14:00:33 +0100")

* Szabolcs Nagy via Libc-alpha:

> A separate asm file is easier to maintain than a macro that expands to
> inline asm.
>
> The RTLD_START macro is only needed now because _dl_start is local in
> rtld.c, but _start has to call it, if _dl_start was made hidden then it
> could be empty.
>
> _dl_skip_args is no longer handled in the _start asm, instead we rely
> on DL_NEED_START_ARGS_ADJUST.

This version looks okay to me.  You can probably push this as an aarch64
maintainer.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


      reply	other threads:[~2022-05-03 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 13:00 [PATCH v3 0/2] Args adjustment with ./ld.so exe [BZ #23293] Szabolcs Nagy
2022-04-13 13:00 ` [PATCH v3 1/2] aarch64: Use generic argv adjustment in ld.so " Szabolcs Nagy
2022-05-03 11:53   ` Florian Weimer
2022-05-03 16:53     ` Szabolcs Nagy
2022-05-03 17:00       ` Florian Weimer
2022-04-13 13:00 ` [PATCH v3 2/2] aarch64: Move ld.so _start to separate file and drop _dl_skip_args Szabolcs Nagy
2022-05-03 11:53   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d72x273.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).