public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] powerpc32: Remove unused HAVE_PPC_SECURE_PLT
@ 2022-05-02  6:29 Fangrui Song
  2022-05-02  8:34 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: Fangrui Song @ 2022-05-02  6:29 UTC (permalink / raw)
  To: libc-alpha, Tulio Magno Quites Machado Filho

82a79e7d1843f9d90075a0bf2f04557040829bb0 removed the only user of
HAVE_PPC_SECURE_PLT.
---
 config.h.in                            |  3 ---
 sysdeps/powerpc/powerpc32/configure    | 27 --------------------------
 sysdeps/powerpc/powerpc32/configure.ac | 14 -------------
 3 files changed, 44 deletions(-)

diff --git a/config.h.in b/config.h.in
index 916465fce8..dd650ddd09 100644
--- a/config.h.in
+++ b/config.h.in
@@ -153,9 +153,6 @@
 /* Define if inlined system calls are available.  */
 #undef HAVE_INLINED_SYSCALLS
 
-/* Define if your compiler defaults to -msecure-plt mode on ppc.  */
-#undef HAVE_PPC_SECURE_PLT
-
 /* Define if memory tagging support should be enabled.  */
 #undef USE_MTAG
 
diff --git a/sysdeps/powerpc/powerpc32/configure b/sysdeps/powerpc/powerpc32/configure
index 551505327a..eb1bcbe651 100644
--- a/sysdeps/powerpc/powerpc32/configure
+++ b/sysdeps/powerpc/powerpc32/configure
@@ -3,30 +3,3 @@
 
 $as_echo "#define HIDDEN_VAR_NEEDS_DYNAMIC_RELOC 1" >>confdefs.h
 
-
-# See whether GCC uses -msecure-plt.
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -msecure-plt by default" >&5
-$as_echo_n "checking for -msecure-plt by default... " >&6; }
-if ${libc_cv_ppc_secure_plt+:} false; then :
-  $as_echo_n "(cached) " >&6
-else
-  echo 'int foo (void) { extern int bar; return bar; }' > conftest.c
-libc_cv_ppc_secure_plt=no
-if { ac_try='${CC-cc} -S $CFLAGS conftest.c -fpic -o conftest.s 1>&5'
-  { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
-  (eval $ac_try) 2>&5
-  ac_status=$?
-  $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
-  test $ac_status = 0; }; }; then
-  if grep '_GLOBAL_OFFSET_TABLE_-.*@ha' conftest.s > /dev/null 2>&1; then
-    libc_cv_ppc_secure_plt=yes
-  fi
-fi
-rm -rf conftest*
-fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_ppc_secure_plt" >&5
-$as_echo "$libc_cv_ppc_secure_plt" >&6; }
-if test $libc_cv_ppc_secure_plt = yes; then
-  $as_echo "#define HAVE_PPC_SECURE_PLT 1" >>confdefs.h
-
-fi
diff --git a/sysdeps/powerpc/powerpc32/configure.ac b/sysdeps/powerpc/powerpc32/configure.ac
index 2f0ea63e0d..158f464b95 100644
--- a/sysdeps/powerpc/powerpc32/configure.ac
+++ b/sysdeps/powerpc/powerpc32/configure.ac
@@ -2,17 +2,3 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
 # Local configure fragment for sysdeps/powerpc/powerpc32.
 
 AC_DEFINE(HIDDEN_VAR_NEEDS_DYNAMIC_RELOC)
-
-# See whether GCC uses -msecure-plt.
-AC_CACHE_CHECK(for -msecure-plt by default, libc_cv_ppc_secure_plt, [dnl
-echo 'int foo (void) { extern int bar; return bar; }' > conftest.c
-libc_cv_ppc_secure_plt=no
-if AC_TRY_COMMAND(${CC-cc} -S $CFLAGS conftest.c -fpic -o conftest.s 1>&AS_MESSAGE_LOG_FD); then
-  if grep '_GLOBAL_OFFSET_TABLE_-.*@ha' conftest.s > /dev/null 2>&1; then
-    libc_cv_ppc_secure_plt=yes
-  fi
-fi
-rm -rf conftest*])
-if test $libc_cv_ppc_secure_plt = yes; then
-  AC_DEFINE(HAVE_PPC_SECURE_PLT)
-fi
-- 
2.36.0.464.gb9c8b46e94-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc32: Remove unused HAVE_PPC_SECURE_PLT
  2022-05-02  6:29 [PATCH] powerpc32: Remove unused HAVE_PPC_SECURE_PLT Fangrui Song
@ 2022-05-02  8:34 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2022-05-02  8:34 UTC (permalink / raw)
  To: Fangrui Song via Libc-alpha
  Cc: Tulio Magno Quites Machado Filho, Fangrui Song

* Fangrui Song via Libc-alpha:

> 82a79e7d1843f9d90075a0bf2f04557040829bb0 removed the only user of
> HAVE_PPC_SECURE_PLT.

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-02  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02  6:29 [PATCH] powerpc32: Remove unused HAVE_PPC_SECURE_PLT Fangrui Song
2022-05-02  8:34 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).