Re: [PATCH 1/2] Implement strlcpy and strlcat [BZ #178]

[Florian Weimer <fweimer@redhat.com>]

* Siddhesh Poyarekar:

> On 2023-04-05 07:20, Florian Weimer via Libc-alpha wrote:
>> --- a/debug/Makefile
>> +++ b/debug/Makefile
>> @@ -31,6 +31,7 @@ headers	:= execinfo.h
>>   routines  = backtrace backtracesyms backtracesymsfd noophooks \
>>   	    memcpy_chk memmove_chk mempcpy_chk memset_chk stpcpy_chk \
>>   	    strcat_chk strcpy_chk strncat_chk strncpy_chk stpncpy_chk \
>> +	    strlcpy_chk strlcat_chk \
>
> Do you want to commit an obvious change first to update this routine
> list to be one per line?

I supoose I could do that, also for string and wcsmbs.

>> diff --git a/manual/string.texi b/manual/string.texi
>> index e06433187e..e3979f1d0f 100644
>> --- a/manual/string.texi
>> +++ b/manual/string.texi
>> @@ -1068,6 +1068,60 @@ processing text.  Also, this function has significant performance
>>   issues.  @xref{Concatenating Strings}.
>>   @end deftypefun
>>   +@deftypefun size_t strlcpy (char *restrict @var{to}, const char
>> *restrict @var{from}, size_t @var{size})
>> +@standards{BSD, string.h}
>
> Should we also mention POSIX here?

It would be misleading because it's not possible to enable this using
_POSIX_SOURCE, I think.

Thanks,
Florian