From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: libc-alpha@sourceware.org
Cc: Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH v2 0/4] PowerPC64 static-pie
Date: Fri, 08 Apr 2022 19:27:32 -0300 [thread overview]
Message-ID: <878rsf2otn.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220228064052.3413334-1-amodra@gmail.com>
Alan Modra via Libc-alpha <libc-alpha@sourceware.org> writes:
> This is a repost of the series at
> https://sourceware.org/pipermail/libc-alpha/2022-January/135598.html
> incorporating review comments.
>
> Changes are:
> - subject lines changed to comply with glibc commit log standards
> - patch 1/4 log now mentions making a couple of symbols hidden
> - patch 2/4 makes at_platform available to early ifunc resolvers
> as well as hwcap.
> - patch 3/4 log mentions stinfo->init and stinfo->fini being unused
> - patch 4/4 PI_STATIC_AND_HIDDEN comment explains what is going on
>
> patch 2/4 is the only code change from the previous series. Testsuite
> results now show no regressions on powerpc64le-linux.
I'm still seeing the following failures on powerpc64le-linux:
FAIL: elf/tst-tls1-static-non-pie
FAIL: gmon/tst-gmon-static
FAIL: gmon/tst-gmon-static-gprof
Am I missing anything?
I used different GCC and Binutils versions ranging between:
- GCC v8 and v11
- Binutils 2.30 and 2.38 (2020-03-04)
Anyway, this is a summary of what I think about these patches:
- Patch 1: Looks good to me.
- Patch 2: Looks good to me.
- Patch 3: Looks good to me after a minor change.
- Patch 4: Hopefully I'm just missing a detail. Otherwise, I believe we should
delay it until the previous issues are fixed.
Let me elaborate this replying to each patch.
--
Tulio Magno
next prev parent reply other threads:[~2022-04-08 22:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 12:42 [PowerPC64] Use medium model toc accesses throughout Alan Modra
2022-01-24 3:47 ` [PATCH 2/5] [PowerPC64] Set up thread register for _dl_relocate_static_pie Alan Modra
2022-02-16 23:02 ` Paul E Murphy
2022-02-19 0:49 ` Alan Modra
2022-01-24 3:50 ` [PATCH 3/5] [PowerPC] Relocate stinfo->main Alan Modra
2022-01-24 4:48 ` H.J. Lu
2022-01-24 6:51 ` Alan Modra
2022-01-24 3:52 ` [PATCH 4/5] Constify a variable in dl_vdso_vsym Alan Modra
2022-01-24 4:06 ` [PATCH 5/5] Enable static-pie on powerpc64 Alan Modra
2022-01-27 18:39 ` Florian Weimer
2022-01-28 8:45 ` Alan Modra
2022-01-28 17:48 ` [PowerPC64] Use medium model toc accesses throughout Paul E Murphy
2022-01-29 1:24 ` Alan Modra
2022-02-28 6:40 ` [PATCH v2 0/4] PowerPC64 static-pie Alan Modra
2022-02-28 6:40 ` [PATCH v2 1/4] powerpc64: Use medium model toc accesses throughout Alan Modra
2022-04-08 22:28 ` Tulio Magno Quites Machado Filho
2022-02-28 6:40 ` [PATCH v2 2/4] powerpc64: Set up thread register for _dl_relocate_static_pie Alan Modra
2022-04-08 22:28 ` Tulio Magno Quites Machado Filho
2022-02-28 6:40 ` [PATCH v2 3/4] powerpc: Relocate stinfo->main Alan Modra
2022-04-08 22:32 ` Tulio Magno Quites Machado Filho
2022-02-28 6:40 ` [PATCH v2 4/4] powerpc64: Enable static-pie Alan Modra
2022-04-08 22:49 ` Tulio Magno Quites Machado Filho
2022-04-14 1:16 ` Alan Modra
2022-04-14 3:42 ` Fangrui Song
2022-04-20 7:21 ` [PATCH v3] " Alan Modra
2022-03-04 12:48 ` [PATCH v2 0/4] PowerPC64 static-pie Alan Modra
2022-04-08 8:06 ` Alan Modra
2022-04-09 0:14 ` Fangrui Song
2022-04-14 0:33 ` Alan Modra
2022-04-14 1:54 ` DT_RELR without libc.so dependency H.J. Lu
2022-04-14 3:43 ` Fangrui Song
2022-04-14 5:18 ` Alan Modra
2022-04-14 17:55 ` H.J. Lu
2022-04-08 22:27 ` Tulio Magno Quites Machado Filho [this message]
2022-04-11 1:38 ` [PATCH v2 0/4] PowerPC64 static-pie Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsf2otn.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).