public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: Raoni Fassina Firmino <raoni@linux.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64le: Fix ifunc selection for memset, memmove, bzero and bcopy
Date: Fri, 07 May 2021 17:04:17 -0300	[thread overview]
Message-ID: <878s4qxqda.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210503195935.je5jbi6hjbiiaovs@work-tp>

Raoni Fassina Firmino via Libc-alpha <libc-alpha@sourceware.org> writes:

> The hwcap2 check for the aforementioned functions should check for
> both PPC_FEATURE2_ARCH_3_1 and PPC_FEATURE2_HAS_ISEL but was
> mistakenly checking for any one of them, enabling isa 3.1 version of
> the functions in incompatible processors, like POWER8.

LGTM.  This time, tested on POWER8 too.

Pushed as 17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707.

Thank you!

-- 
Tulio Magno

      parent reply	other threads:[~2021-05-07 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 19:59 Raoni Fassina Firmino
2021-05-04 13:31 ` Lucas A. M. Magalhaes
2021-05-04 17:48 ` Raphael M Zinsly
2021-05-06 14:09   ` Raoni Fassina Firmino
2021-05-07 20:04 ` Tulio Magno Quites Machado Filho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s4qxqda.fsf@linux.ibm.com \
    --to=tuliom@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=raoni@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).