From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 7/7] misc: Use gmtime instead of localtime
Date: Mon, 21 Mar 2022 12:25:29 +0100 [thread overview]
Message-ID: <87a6djo8d2.fsf@igel.home> (raw)
In-Reply-To: <20220318165214.2291065-8-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 18 Mar 2022 13:52:14 -0300")
On Mär 18 2022, Adhemerval Zanella via Libc-alpha wrote:
> diff --git a/misc/syslog.c b/misc/syslog.c
> index 7852441615..997e423228 100644
> --- a/misc/syslog.c
> +++ b/misc/syslog.c
> @@ -161,11 +161,25 @@ __vsyslog_internal(int pri, const char *fmt, va_list ap,
>
> /* "%h %e %H:%M:%S " */
> char timestamp[timestamp_size];
> - time_t now = time_now ();
> + __time64_t now = time64_now ();
> +
> + /* We deviate from RFC3164 which states timestamp should be in localtime
> + because although our __localtime_r does not set tzname, the relay still
> + might still use localtime (which does) and if the server timezone changes
s/still...still/still/
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-03-21 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 16:52 [PATCH v3 0/7] Refactor syslog implementation Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 1/7] support: Add xmkfifo Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 2/7] misc: Add syslog test Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 3/7] misc: syslog: Fix indentation and style Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 4/7] misc: syslog: Simplify implementation Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 5/7] misc: syslog: Use fixed-sized buffer Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Adhemerval Zanella
2022-03-18 16:52 ` [PATCH v3 7/7] misc: Use gmtime instead of localtime Adhemerval Zanella
2022-03-21 11:25 ` Andreas Schwab [this message]
2022-03-18 21:11 ` [PATCH v3 0/7] Refactor syslog implementation Paul Eggert
2022-03-21 14:10 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6djo8d2.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).