From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
crrodriguez@opensuse.org
Subject: Re: [PATCH 1/4] Remove architecture specific sched_cpucount optimizations
Date: Wed, 05 May 2021 19:28:20 +0200 [thread overview]
Message-ID: <87a6p9dr9n.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210329182520.323665-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 29 Mar 2021 15:25:17 -0300")
* Adhemerval Zanella via Libc-alpha:
> diff --git a/posix/sched_cpucount.c b/posix/sched_cpucount.c
> index b0ca4ea7bc..529286e777 100644
> --- a/posix/sched_cpucount.c
> +++ b/posix/sched_cpucount.c
> @@ -22,31 +22,11 @@ int
> __sched_cpucount (size_t setsize, const cpu_set_t *setp)
> {
> int s = 0;
> + for (int i = 0; i < setsize / sizeof (__cpu_mask); i++)
> {
> + __cpu_mask si = setp->__bits[i];
> + /* Clear the least significant bit set. */
> + for (; si != 0; si &= si - 1, s++);
> }
> -
> return s;
> }
Why “si”? It think si &= si - 1 clears the *most* significant bit in
si. If you agree, please update the comment.
The rest looks okay to me.
Thanks,
Florian
next prev parent reply other threads:[~2021-05-05 17:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 18:25 Adhemerval Zanella
2021-03-29 18:25 ` [PATCH 2/4] linux: Use sched_getaffinity for __get_nprocs (BZ #27645) Adhemerval Zanella
2021-04-27 15:38 ` Florian Weimer
2021-03-29 18:25 ` [PATCH 3/4] linux: Use /sys/devices/system/cpu/possible on __get_nprocs_conf Adhemerval Zanella
2021-05-05 16:53 ` Adhemerval Zanella
2021-05-05 17:54 ` Florian Weimer
2021-05-05 18:06 ` Florian Weimer
2021-05-06 13:03 ` Adhemerval Zanella
2021-05-06 13:51 ` Florian Weimer
2021-05-06 20:07 ` Adhemerval Zanella
2021-05-07 11:07 ` Florian Weimer
2021-05-07 12:43 ` Adhemerval Zanella
2021-05-06 13:17 ` Adhemerval Zanella
2021-03-29 18:25 ` [PATCH 4/4] linux: Remove /proc/cpuinfo fallback on alpha and sparc Adhemerval Zanella
2021-05-05 16:53 ` Adhemerval Zanella
2021-05-05 16:52 ` [PATCH 1/4] Remove architecture specific sched_cpucount optimizations Adhemerval Zanella
2021-05-05 17:28 ` Florian Weimer [this message]
2021-05-05 18:25 ` Paul Eggert
2021-05-05 19:52 ` Noah Goldstein
2021-05-06 12:22 ` Adhemerval Zanella
2021-05-06 18:34 ` Noah Goldstein
2021-05-06 13:33 ` Adhemerval Zanella
2021-05-06 13:43 ` Florian Weimer
2021-05-06 16:16 ` Adhemerval Zanella
2021-05-06 16:42 ` Florian Weimer
2021-05-06 16:54 ` Adhemerval Zanella
2021-05-06 17:12 ` Paul Eggert
2021-05-06 17:51 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6p9dr9n.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=crrodriguez@opensuse.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).