From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: <libc-alpha@sourceware.org>, Khem Raj <raj.khem@gmail.com>,
Ross Burton <ross.burton@arm.com>
Subject: Re: [PATCH] aarch64: fix check for SVE support in assembler
Date: Thu, 14 Mar 2024 14:57:15 +0100 [thread overview]
Message-ID: <87bk7glxvo.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20240314133012.16925-1-szabolcs.nagy@arm.com> (Szabolcs Nagy's message of "Thu, 14 Mar 2024 13:30:12 +0000")
* Szabolcs Nagy:
> Due to GCC bug 110901 -mcpu can override -march setting when compiling
> asm code and thus a compiler targetting a specific cpu can fail the
> configure check even when binutils gas supports SVE.
>
> The workaround is that explicit .arch directive overrides both -mcpu
> and -march, and since that's what the actual SVE memcpy uses the
> configure check should use that too even if the GCC issue is fixed
> independently.
> ---
>
> note: i found this in yocto, and i think it's a better fix than
> https://git.yoctoproject.org/poky/tree/meta/recipes-core/glibc/glibc/0023-aarch64-configure-Pass-mcpu-along-with-march-to-dete.patch
Mechanics look reasonable.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2024-03-14 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 13:30 Szabolcs Nagy
2024-03-14 13:57 ` Florian Weimer [this message]
2024-03-14 17:27 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk7glxvo.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=raj.khem@gmail.com \
--cc=ross.burton@arm.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).