Re: [PATCH] aarch64: fix check for SVE support in assembler

[Khem Raj <raj.khem@gmail.com>]

On Thu, Mar 14, 2024 at 6:57 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Szabolcs Nagy:
>
> > Due to GCC bug 110901 -mcpu can override -march setting when compiling
> > asm code and thus a compiler targetting a specific cpu can fail the
> > configure check even when binutils gas supports SVE.
> >
> > The workaround is that explicit .arch directive overrides both -mcpu
> > and -march, and since that's what the actual SVE memcpy uses the
> > configure check should use that too even if the GCC issue is fixed
> > independently.
> > ---
> >
> > note: i found this in yocto, and i think it's a better fix than
> > https://git.yoctoproject.org/poky/tree/meta/recipes-core/glibc/glibc/0023-aarch64-configure-Pass-mcpu-along-with-march-to-dete.patch
>
> Mechanics look reasonable.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>

LGTM, the yocto patch was just a workaround to wait on GCC to fix the
problem, but this solves is properly within glibc and does not
need to wait on gcc fix. I will test it out.

>
> Thanks,
> Florian
>