From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: caiyinyu <caiyinyu@loongson.cn>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
xuchenghua@loongson.cn, joseph_myers@mentor.com
Subject: Re: [PATCH v4 04/13] LoongArch: ABI Implementation
Date: Mon, 09 May 2022 14:46:52 +0200 [thread overview]
Message-ID: <87bkw6an5v.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <44834807-c008-45dd-3cea-b3beab266ad8@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 9 May 2022 09:39:03 -0300")
* Adhemerval Zanella via Libc-alpha:
>> +/* Return nonzero iff ELF header is compatible with the running host. */
>> +static inline int __attribute_used__
>
> I am almost sure that with GNU C11 that we use to build glibc there is no need
> to use __attribute_used__. I take you are copy/paste from other ports, but it
> would be goot to see if we can clean this up.
And __attribute_used__ does more than suppressing the warning: it also
emits a copy for access from assembler code (which is not needed here).
Thanks,
Florian
next prev parent reply other threads:[~2022-05-09 12:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 2:29 [PATCH v4 00/13] GLIBC LoongArch PATCHES caiyinyu
2022-05-09 2:29 ` [PATCH v4 01/13] LoongArch: Update NEWS and README for the LoongArch port caiyinyu
2022-05-09 2:29 ` [PATCH v4 02/13] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2022-05-09 2:30 ` [PATCH v4 03/13] LoongArch: Add relocations and ELF flags to elf.h and scripts/glibcelf.py caiyinyu
2022-05-09 2:30 ` [PATCH v4 04/13] LoongArch: ABI Implementation caiyinyu
2022-05-09 7:56 ` Fangrui Song
2022-05-24 9:49 ` 回复: " caiyinyu
2022-05-24 19:55 ` Fangrui Song
2022-05-09 8:20 ` Fangrui Song
2022-05-09 11:33 ` Adhemerval Zanella
2022-05-09 12:39 ` Adhemerval Zanella
2022-05-09 12:46 ` Florian Weimer [this message]
2022-05-29 13:10 ` Adhemerval Zanella
2022-05-09 2:30 ` [PATCH v4 05/13] LoongArch: Thread-Local Storage Support caiyinyu
2022-05-09 2:30 ` [PATCH v4 06/13] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-05-09 2:30 ` [PATCH v4 07/13] LoongArch: Atomic and Locking Routines caiyinyu
2022-05-09 2:30 ` [PATCH v4 08/13] LoongArch: Linux Syscall Interface caiyinyu
2022-05-09 2:30 ` [PATCH v4 09/13] LoongArch: Linux ABI caiyinyu
2022-05-09 2:30 ` [PATCH v4 10/13] LoongArch: Add ABI Lists caiyinyu
-- strict thread matches above, loose matches on Subject: below --
2022-05-09 2:25 [PATCH v3 00/13] GLIBC LoongArch PATCHES caiyinyu
2022-05-09 2:26 ` [PATCH v4 04/13] LoongArch: ABI Implementation caiyinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkw6an5v.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).