public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: libc-alpha@sourceware.org,  syq@debian.org,
	 jiaxun.yang@flygoat.com, aurelien@aurel32.net,
	 macro@orcam.me.uk
Subject: Re: [PATCH v2 2/2] MIPS: N64, make xstat as wrapper of generic fstatat
Date: Fri, 19 Mar 2021 11:07:33 +0100	[thread overview]
Message-ID: <87czvv78yi.fsf@igel.home> (raw)
In-Reply-To: <20210319011837.3883510-2-yunqiang.su@cipunited.com> (YunQiang Su's message of "Fri, 19 Mar 2021 01:18:37 +0000")

On Mär 19 2021, YunQiang Su wrote:

> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c b/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c
> new file mode 100644
> index 0000000000..037b2bb080
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c
> @@ -0,0 +1,27 @@
> +/* fxstat using old-style Unix stat system call.
> +   Copyright (C) 1991-2021 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +#include <sys/stat.h>
> +#include <fcntl.h>
> +
> +/* Get information about the file NAME in BUF.  */
> +int
> +__fxstat (int vers, int fd, struct stat *buf)
> +{
> +   return __fxstatat(vers, fd, "", buf, AT_EMPTY_PATH);

That needs to reject fd < 0.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2021-03-19 10:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  1:18 [PATCH v2 1/2] fstatat64: use statx on kernel using uint32 for time YunQiang Su
2021-03-19  1:18 ` [PATCH v2 2/2] MIPS: N64, make xstat as wrapper of generic fstatat YunQiang Su
2021-03-19 10:07   ` Andreas Schwab [this message]
2021-03-19 18:42   ` Adhemerval Zanella
2021-03-22  2:23     ` 回复: " yunqiang.su
2021-03-19 18:38 ` [PATCH v2 1/2] fstatat64: use statx on kernel using uint32 for time Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czvv78yi.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=aurelien@aurel32.net \
    --cc=jiaxun.yang@flygoat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=macro@orcam.me.uk \
    --cc=syq@debian.org \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).