From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] Add _FORTIFY_SOURCE implementation documentation [BZ #28998]
Date: Mon, 09 Jan 2023 16:32:27 +0100 [thread overview]
Message-ID: <87eds3k9kk.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20221222160403.4151387-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 22 Dec 2022 11:04:03 -0500")
* Siddhesh Poyarekar:
> +The following functions are fortified in @theglibc{}:
> +
> +@itemize @bullet
> +@item @code{asprintf}: Replaced with @code{__asprintf_chk}.
> +
> +@item @code{confstr}: Replaced with @code{__confstr_chk}.
> +
> +@item @code{dprintf}: Replaced with @code{__dprintf_chk}.
For the *printf* functions, the replacement depends on the architecture
and compilation mode (the concrete type of long double).
> +@item @code{explicit_bzero}: Replaced with @code{__explicit_bzero_chk}.
> +
> +@item @code{FD_SET}: Replaced with @code{__fdelt_chk}.
> +
> +@item @code{FD_CLR}: Replaced with @code{__fdelt_chk}.
> +
> +@item @code{FD_ISSET}: Replaced with @code{__fdelt_chk}.
These three macros (not functions) aren't replaced, but enhanced.
Maybe just mentioned the list of functions/macros, and point towards the
general pattern, but also note the presence of exceptions?
Rest looks okay to me.
Thanks,
Florian
next prev parent reply other threads:[~2023-01-09 15:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 16:25 [PATCH] " Siddhesh Poyarekar
2022-12-15 16:35 ` Andreas Schwab
2022-12-15 16:37 ` Siddhesh Poyarekar
2022-12-22 12:56 ` Siddhesh Poyarekar
2022-12-22 13:08 ` Sam James
2023-01-03 14:43 ` Siddhesh Poyarekar
2023-01-04 23:49 ` Jeff Law
2022-12-22 13:35 ` Florian Weimer
2022-12-22 14:19 ` Siddhesh Poyarekar
2022-12-22 14:22 ` Siddhesh Poyarekar
2022-12-22 15:32 ` [PATCH v2] " Siddhesh Poyarekar
2022-12-22 16:04 ` [PATCH v3] " Siddhesh Poyarekar
2023-01-03 14:29 ` [ping][PATCH " Siddhesh Poyarekar
2023-01-05 21:04 ` [PATCH " Yann Droneaud
2023-01-06 12:27 ` Siddhesh Poyarekar
2023-01-09 15:32 ` Florian Weimer [this message]
2023-01-10 13:03 ` Siddhesh Poyarekar
2023-01-11 6:45 ` Sam James
2023-01-10 13:40 ` [PATCH v4] " Siddhesh Poyarekar
2023-01-10 15:00 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eds3k9kk.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).