From: Florian Weimer <fw@deneb.enyo.de>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Add .clang-format style file
Date: Wed, 30 Mar 2022 22:14:22 +0200 [thread overview]
Message-ID: <87ee2jgpup.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAFUsyf+=aM=c3nK4AC1NrF0oYz+ns9h+YX7iUHv1+8rhCexP2w@mail.gmail.com> (Noah Goldstein's message of "Wed, 30 Mar 2022 15:09:07 -0500")
* Noah Goldstein:
>> > +UseTab: Never
>>
>> I prefer not using tabs, but others disagree, and most of the source
>> files use tabs instead of 8 spaces (and not just for indentation).
>
> +1 but yeah the consistent style seems to be tabs so will update in v4.
Is there an option to use tabs only if the file contains tab?
>> > +ForEachMacros:
>> > + - 'FOR_EACH_IMPL'
>> > + - 'list_for_each'
>> > + - 'list_for_each_prev'
>> > + - 'list_for_each_prev_safe'
>>
>> If this is a YAML file, do these duplicate FoEachMacros keys have any
>> effect? Only the second one is relevant to glibc.
>
> They all seem to have an effect.
<https://yaml.org/spec/1.2.2/#mapping> says that keys have to be
unique, so I don't think to ForEachMacros is valid YAML syntax.
> What do you mean only the second is relevant?
glibc does not use the Boost and Qt macros.
next prev parent reply other threads:[~2022-03-30 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 19:12 [PATCH v1] " Noah Goldstein
2022-03-30 0:26 ` Fangrui Song
2022-03-30 1:33 ` Noah Goldstein
2022-03-30 17:02 ` [PATCH v2] " Noah Goldstein
2022-03-30 18:17 ` Fangrui Song
2022-03-30 19:30 ` Noah Goldstein
2022-03-30 19:47 ` Joseph Myers
2022-03-30 20:11 ` Noah Goldstein
2022-03-30 20:16 ` Noah Goldstein
2022-03-30 20:21 ` Joseph Myers
2022-03-30 20:59 ` Andreas Schwab
2022-03-30 19:27 ` [PATCH v3] " Noah Goldstein
2022-03-30 19:59 ` Fangrui Song
2022-03-30 20:01 ` Florian Weimer
2022-03-30 20:09 ` Noah Goldstein
2022-03-30 20:14 ` Florian Weimer [this message]
2022-03-30 20:21 ` Noah Goldstein
2022-03-30 20:10 ` [PATCH v4] " Noah Goldstein
2022-03-30 20:24 ` [PATCH v5] " Noah Goldstein
2022-04-04 14:13 ` Carlos O'Donell
2022-04-04 16:57 ` Noah Goldstein
2022-04-04 16:56 ` [PATCH v6] " Noah Goldstein
2022-04-11 14:18 ` Carlos O'Donell
2022-04-11 15:52 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee2jgpup.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).