public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] powerpc64le: Fix typo in configure
@ 2021-07-06 10:19 Anton Blanchard
  2021-07-06 15:00 ` Adhemerval Zanella
  0 siblings, 1 reply; 3+ messages in thread
From: Anton Blanchard @ 2021-07-06 10:19 UTC (permalink / raw)
  To: libc-alpha; +Cc: Tulio Magno Quites Machado Filho

The configure script checks for -mlong-double-128 but mentions -mlongdouble
when it fails.
---
 sysdeps/powerpc/powerpc64/le/configure    | 2 +-
 sysdeps/powerpc/powerpc64/le/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sysdeps/powerpc/powerpc64/le/configure b/sysdeps/powerpc/powerpc64/le/configure
index 98a4889945..35950a6ddd 100644
--- a/sysdeps/powerpc/powerpc64/le/configure
+++ b/sysdeps/powerpc/powerpc64/le/configure
@@ -114,7 +114,7 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_compiler_powerpc64le_ldbl128_mabi" >&5
 $as_echo "$libc_cv_compiler_powerpc64le_ldbl128_mabi" >&6; }
 if test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"; then :
-  critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlongdouble simultaneously."
+  critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."
 fi
 
 for ac_prog in $OBJCOPY
diff --git a/sysdeps/powerpc/powerpc64/le/configure.ac b/sysdeps/powerpc/powerpc64/le/configure.ac
index 769c06709e..9f0423ede2 100644
--- a/sysdeps/powerpc/powerpc64/le/configure.ac
+++ b/sysdeps/powerpc/powerpc64/le/configure.ac
@@ -64,7 +64,7 @@ long double x;
 		  [libc_cv_compiler_powerpc64le_ldbl128_mabi=no])
 CFLAGS="$save_CFLAGS"])
 AS_IF([test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"],
-      [critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlongdouble simultaneously."])
+      [critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."])
 
 dnl objcopy (binutils) 2.26 or newer required to support the --update-section
 dnl feature for fixing up .gnu.attribute section with IEEE ldbl.
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc64le: Fix typo in configure
  2021-07-06 10:19 [PATCH] powerpc64le: Fix typo in configure Anton Blanchard
@ 2021-07-06 15:00 ` Adhemerval Zanella
  2021-07-09  1:01   ` Tulio Magno Quites Machado Filho
  0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2021-07-06 15:00 UTC (permalink / raw)
  To: Anton Blanchard, libc-alpha; +Cc: Tulio Magno Quites Machado Filho



On 06/07/2021 07:19, Anton Blanchard via Libc-alpha wrote:
> The configure script checks for -mlong-double-128 but mentions -mlongdouble
> when it fails.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/powerpc/powerpc64/le/configure    | 2 +-
>  sysdeps/powerpc/powerpc64/le/configure.ac | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sysdeps/powerpc/powerpc64/le/configure b/sysdeps/powerpc/powerpc64/le/configure
> index 98a4889945..35950a6ddd 100644
> --- a/sysdeps/powerpc/powerpc64/le/configure
> +++ b/sysdeps/powerpc/powerpc64/le/configure
> @@ -114,7 +114,7 @@ fi
>  { $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_compiler_powerpc64le_ldbl128_mabi" >&5
>  $as_echo "$libc_cv_compiler_powerpc64le_ldbl128_mabi" >&6; }
>  if test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"; then :
> -  critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlongdouble simultaneously."
> +  critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."
>  fi
>  
>  for ac_prog in $OBJCOPY
> diff --git a/sysdeps/powerpc/powerpc64/le/configure.ac b/sysdeps/powerpc/powerpc64/le/configure.ac
> index 769c06709e..9f0423ede2 100644
> --- a/sysdeps/powerpc/powerpc64/le/configure.ac
> +++ b/sysdeps/powerpc/powerpc64/le/configure.ac
> @@ -64,7 +64,7 @@ long double x;
>  		  [libc_cv_compiler_powerpc64le_ldbl128_mabi=no])
>  CFLAGS="$save_CFLAGS"])
>  AS_IF([test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"],
> -      [critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlongdouble simultaneously."])
> +      [critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."])
>  
>  dnl objcopy (binutils) 2.26 or newer required to support the --update-section
>  dnl feature for fixing up .gnu.attribute section with IEEE ldbl.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc64le: Fix typo in configure
  2021-07-06 15:00 ` Adhemerval Zanella
@ 2021-07-09  1:01   ` Tulio Magno Quites Machado Filho
  0 siblings, 0 replies; 3+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2021-07-09  1:01 UTC (permalink / raw)
  To: Adhemerval Zanella, Anton Blanchard, libc-alpha

Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:

> On 06/07/2021 07:19, Anton Blanchard via Libc-alpha wrote:
>> The configure script checks for -mlong-double-128 but mentions -mlongdouble
>> when it fails.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Pushed as 01d780628278972cfa3630feeb74d7861b0fd5fc.

Thanks!

-- 
Tulio Magno

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-09  1:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 10:19 [PATCH] powerpc64le: Fix typo in configure Anton Blanchard
2021-07-06 15:00 ` Adhemerval Zanella
2021-07-09  1:01   ` Tulio Magno Quites Machado Filho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).