From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] gshadow: Matching sgetsgent, sgetsgent_r ERANGE handling (bug 30151)
Date: Tue, 07 Mar 2023 10:06:06 +0100 [thread overview]
Message-ID: <87fsahq6bl.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <3e3a4797-501d-3df7-c69f-9a715f3f3e0c@gotplt.org> (Siddhesh Poyarekar's message of "Wed, 1 Mar 2023 13:20:22 -0500")
* Siddhesh Poyarekar:
> On 2023-02-21 03:39, Florian Weimer via Libc-alpha wrote:
>> Before this change, sgetsgent_r did not set errno to ERNAGE, but
>
> s/ERNAGE/ERANGE/
>
>> sgetsgent only checked errno, not the return value from sgetsgent_r.
>> Consequently, sgetsgent did not detect any error, and reported
>> success to the caller, without initializing the struct sgrp object
>> whose address was returned.
>> This commit changes sgetsgent_r to set errno as well. This avoids
>> similar issues in applications which only change errno.
>
> ... which only *check* errno?
>
> The patch itself is fine.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Thanks, pushed.
Florian
prev parent reply other threads:[~2023-03-07 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 8:39 Florian Weimer
2023-02-21 9:21 ` Sam James
2023-02-21 9:45 ` Florian Weimer
2023-03-01 18:20 ` Siddhesh Poyarekar
2023-03-07 9:06 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsahq6bl.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).