From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH v4 2/4] rtld: Remove DL_ARGV_NOT_RELRO
Date: Wed, 04 May 2022 11:31:43 +0200 [thread overview]
Message-ID: <87fslptzi8.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <3e12f8fc7eb1050f90fae30b4f20357c638181e6.1651643916.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Wed, 4 May 2022 07:26:54 +0100")
* Szabolcs Nagy via Libc-alpha:
> This is no longer needed because _dl_skip_args is always 0, so the
> target specific code that modifies argv after relro protection is
> applied is no longer used.
>
> After the patch relro protection is applied to _dl_argv consistently
> on all targets.
I double-checked and as far as I can tell, the _dl_argv update is indeed
conditional on _dl_skip_args != 0. Maybe you could define _dl_skip_args
as const and add a comment that it is there for the benefit of
non-yet-ported startup code, but maybe we can clean this up quickly so
that it does not matter.
Tested on s390-linux-gnu and s390x-linux-gnu, powerpc64le-linux-gnu.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Tested-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2022-05-04 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 6:26 [PATCH v4 0/4] Args adjustment with ./ld.so exe [BZ #23293] Szabolcs Nagy
2022-05-04 6:26 ` [PATCH v4 1/4] rtld: Use generic argv adjustment in ld.so " Szabolcs Nagy
2022-05-04 9:28 ` Florian Weimer
2022-05-04 6:26 ` [PATCH v4 2/4] rtld: Remove DL_ARGV_NOT_RELRO Szabolcs Nagy
2022-05-04 9:31 ` Florian Weimer [this message]
2022-05-04 6:27 ` [PATCH v4 3/4] linux: Add a getauxval test [BZ #23293] Szabolcs Nagy
2022-05-04 9:32 ` Florian Weimer
2022-05-04 6:27 ` [PATCH v4 4/4] aarch64: Move ld.so _start to separate file and drop _dl_skip_args Szabolcs Nagy
2022-05-04 9:33 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fslptzi8.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).