From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 10/10] dirent: Deprecate getdirentries
Date: Wed, 22 Apr 2020 12:10:32 +0200 [thread overview]
Message-ID: <87ftcvltk7.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20200417132209.22065-10-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 17 Apr 2020 10:22:09 -0300")
* Adhemerval Zanella via Libc-alpha:
> diff --git a/NEWS b/NEWS
> index 2424fecdc0..58d9db6d00 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -22,6 +22,9 @@ Deprecated and removed features, and other changes affecting compatibility:
> but always fails with ENOSYS. This reflects the removal of the system
> call from all architectures, starting with Linux 5.5.
>
> +* The function getdirentries is now deprecated, applications should use
> + either getdents or POSIX readdir instead.
getdents64, readdir64 or readdir
> diff --git a/dirent/dirent.h b/dirent/dirent.h
> index 92d0925047..4ee60471f7 100644
> --- a/dirent/dirent.h
> +++ b/dirent/dirent.h
> @@ -353,14 +353,15 @@ extern int alphasort64 (const struct dirent64 **__e1,
> extern __ssize_t getdirentries (int __fd, char *__restrict __buf,
> size_t __nbytes,
> __off_t *__restrict __basep)
> - __THROW __nonnull ((2, 4));
> + __THROW __nonnull ((2, 4)) __attribute_deprecated__;
> # else
> # ifdef __REDIRECT
> extern __ssize_t __REDIRECT_NTH (getdirentries,
> (int __fd, char *__restrict __buf,
> size_t __nbytes,
> __off64_t *__restrict __basep),
> - getdirentries64) __nonnull ((2, 4));
> + getdirentries64)
> + __THROW __nonnull ((2, 4)) __attribute_deprecated__;
> # else
> # define getdirentries getdirentries64
> # endif
> @@ -370,7 +371,7 @@ extern __ssize_t __REDIRECT_NTH (getdirentries,
> extern __ssize_t getdirentries64 (int __fd, char *__restrict __buf,
> size_t __nbytes,
> __off64_t *__restrict __basep)
> - __THROW __nonnull ((2, 4));
> + __THROW __nonnull ((2, 4)) __attribute_deprecated__;
> # endif
> #endif /* Use misc. */
Please add a message pointing to readdir64 (probably in both cases).
next prev parent reply other threads:[~2020-04-22 10:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:22 [PATCH 01/10] linux: Move posix dir implementations to Linux Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 02/10] linux: Simplify opendir buffer allocation Adhemerval Zanella
2020-04-21 10:28 ` Florian Weimer
2020-04-23 21:27 ` Rafal Luzynski
2020-04-29 17:09 ` Adhemerval Zanella
2020-04-23 21:39 ` Adhemerval Zanella
2020-04-24 10:11 ` Florian Weimer
2020-04-24 12:08 ` Adhemerval Zanella
2020-04-24 13:08 ` Florian Weimer
2020-04-17 13:22 ` [PATCH 03/10] linux: Add __readdir_unlocked Adhemerval Zanella
2020-04-21 10:41 ` Florian Weimer
2020-04-21 12:03 ` Adhemerval Zanella
2020-04-21 12:16 ` Florian Weimer
2020-04-21 13:00 ` Adhemerval Zanella
2020-05-27 16:38 ` Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 04/10] linux: Use internal DIR locks when accessing filepos on telldir Adhemerval Zanella
2020-04-21 10:33 ` Florian Weimer
2020-04-17 13:22 ` [PATCH 05/10] linux: Use getdents64 on non-LFS readdir Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 06/10] linux: Set internal DIR filepos as off64_t [BZ #23960, BZ #24050] Adhemerval Zanella
2020-04-20 15:01 ` Andreas Schwab
2020-04-20 15:02 ` Florian Weimer
2020-04-20 15:06 ` Andreas Schwab
2020-04-21 12:04 ` Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 07/10] linux: Add __readdir64_unlocked Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 08/10] linux: Add __old_readdir64_unlocked Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 09/10] linux: Use getdents64 on readdir64 compat implementation Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 10/10] dirent: Deprecate getdirentries Adhemerval Zanella
2020-04-22 10:10 ` Florian Weimer [this message]
2020-04-20 14:53 ` [PATCH 01/10] linux: Move posix dir implementations to Linux Andreas Schwab
2020-04-21 10:15 ` Florian Weimer
2020-04-21 11:51 ` Adhemerval Zanella
2020-05-27 16:35 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcvltk7.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).