From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 02/10] linux: Simplify opendir buffer allocation
Date: Fri, 24 Apr 2020 15:08:20 +0200 [thread overview]
Message-ID: <87lfml9gl7.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <a23c6130-77b4-3c28-d56c-89cbb0dc0e4d@linaro.org> (Adhemerval Zanella's message of "Fri, 24 Apr 2020 09:08:49 -0300")
* Adhemerval Zanella:
> On 24/04/2020 07:11, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>>> This looks okay to me. I wonder if we should just use 32 KiB
>>>> uncodintionally, though?
>>>
>>> Do you mean instead of '4 * BUFSIZ'?
>>
>> Yes. I assumed BUFSIZ was 8192.
>>
>
> Alright, I can make this change. Any opinion whether we should keep
> 32 KiB or increase/decrease it?
Sorry, I think it should be a separate change. Lowering the buffer
size will unfortunately expose application bugs when applications
modify the directory while iterating through it using readdir. (musl
sees more such bugs due to its smaller buffer size.)
next prev parent reply other threads:[~2020-04-24 13:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:22 [PATCH 01/10] linux: Move posix dir implementations to Linux Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 02/10] linux: Simplify opendir buffer allocation Adhemerval Zanella
2020-04-21 10:28 ` Florian Weimer
2020-04-23 21:27 ` Rafal Luzynski
2020-04-29 17:09 ` Adhemerval Zanella
2020-04-23 21:39 ` Adhemerval Zanella
2020-04-24 10:11 ` Florian Weimer
2020-04-24 12:08 ` Adhemerval Zanella
2020-04-24 13:08 ` Florian Weimer [this message]
2020-04-17 13:22 ` [PATCH 03/10] linux: Add __readdir_unlocked Adhemerval Zanella
2020-04-21 10:41 ` Florian Weimer
2020-04-21 12:03 ` Adhemerval Zanella
2020-04-21 12:16 ` Florian Weimer
2020-04-21 13:00 ` Adhemerval Zanella
2020-05-27 16:38 ` Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 04/10] linux: Use internal DIR locks when accessing filepos on telldir Adhemerval Zanella
2020-04-21 10:33 ` Florian Weimer
2020-04-17 13:22 ` [PATCH 05/10] linux: Use getdents64 on non-LFS readdir Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 06/10] linux: Set internal DIR filepos as off64_t [BZ #23960, BZ #24050] Adhemerval Zanella
2020-04-20 15:01 ` Andreas Schwab
2020-04-20 15:02 ` Florian Weimer
2020-04-20 15:06 ` Andreas Schwab
2020-04-21 12:04 ` Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 07/10] linux: Add __readdir64_unlocked Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 08/10] linux: Add __old_readdir64_unlocked Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 09/10] linux: Use getdents64 on readdir64 compat implementation Adhemerval Zanella
2020-04-17 13:22 ` [PATCH 10/10] dirent: Deprecate getdirentries Adhemerval Zanella
2020-04-22 10:10 ` Florian Weimer
2020-04-20 14:53 ` [PATCH 01/10] linux: Move posix dir implementations to Linux Andreas Schwab
2020-04-21 10:15 ` Florian Weimer
2020-04-21 11:51 ` Adhemerval Zanella
2020-05-27 16:35 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfml9gl7.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).