public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142, bug 14697)
Date: Mon, 17 Feb 2020 12:46:00 -0000	[thread overview]
Message-ID: <87ftf9crij.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <mvmh7zpa6gx.fsf@suse.de> (Andreas Schwab's message of "Mon, 17 Feb 2020 10:49:50 +0100")

* Andreas Schwab:

> On Feb 17 2020, Florian Weimer wrote:
>
>> * Andreas Schwab:
>>
>>> On Feb 16 2020, Florian Weimer wrote:
>>>
>>>> I'm not sure if the justification is correct.  We don't know if there
>>>> are programs which call flockfile on some file and expect exit to
>>>> still work (and terminate the program), which is part of what
>>>> nptl/tst-stdio1 tests.
>>>
>>> But that's exactly what the bug is about.  Random memory corruption
>>> cannot be the answer.
>>
>> Sure, but breaking existing programs so that they never terminate is
>> not acceptable, either.
>
> They were always erroneous.

Yes, but we might be heading towards another memcpy or glob situation
here, where we had to bump symbol versions to keep important (but broken)
software running.

  reply	other threads:[~2020-02-17 12:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 14:01 Andreas Schwab
2020-02-16 13:40 ` Florian Weimer
2020-02-17  9:19   ` Andreas Schwab
2020-02-17  9:42     ` Florian Weimer
2020-02-17  9:49       ` Andreas Schwab
2020-02-17 12:46         ` Florian Weimer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-29 13:09 Andreas Schwab
2023-06-30 15:57 ` Florian Weimer
2023-07-03  7:34   ` Andreas Schwab
2023-07-03  7:53     ` Florian Weimer
2023-06-06 14:11 Andreas Schwab
2023-06-05 10:36 Andreas Schwab
2022-07-18 11:45 Andreas Schwab
2019-12-11  9:55 Andreas Schwab
2019-11-25 14:20 Andreas Schwab
2019-11-25 15:05 ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftf9crij.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).