From: Andreas Schwab <schwab@suse.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Andreas Schwab via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142, bug 14697)
Date: Mon, 03 Jul 2023 09:34:25 +0200 [thread overview]
Message-ID: <mvmr0pptpmm.fsf@suse.de> (raw)
In-Reply-To: <878rc1vt7g.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Fri, 30 Jun 2023 17:57:23 +0200")
On Jun 30 2023, Florian Weimer wrote:
> * Andreas Schwab via Libc-alpha:
>
>> Now that abort no longer calls fflush there is no reason to avoid locking
>> the stdio streams anywhere. This fixes a conformance issue and potential
>> heap corruption during exit.
>
> Mechanics of the patch look okay to me. In the end, we may have to make
> this configurable if too many applications hang during shutdown, but I
> think we should put it into the upcoming release.
This has been part of SUSE/openSUSE for several years, and I have not
seen any complaints so far. It's more likely that you get a crash
during the unlocked access to the streams.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-07-03 7:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:09 Andreas Schwab
2023-06-30 15:57 ` Florian Weimer
2023-07-03 7:34 ` Andreas Schwab [this message]
2023-07-03 7:53 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2023-06-06 14:11 Andreas Schwab
2023-06-05 10:36 Andreas Schwab
2022-07-18 11:45 Andreas Schwab
2020-02-13 14:01 Andreas Schwab
2020-02-16 13:40 ` Florian Weimer
2020-02-17 9:19 ` Andreas Schwab
2020-02-17 9:42 ` Florian Weimer
2020-02-17 9:49 ` Andreas Schwab
2020-02-17 12:46 ` Florian Weimer
2019-12-11 9:55 Andreas Schwab
2019-11-25 14:20 Andreas Schwab
2019-11-25 15:05 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmr0pptpmm.fsf@suse.de \
--to=schwab@suse.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).