From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: Torvald Riegel <triegel@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Document a behavior of an elided pthread_rwlock_unlock
Date: Fri, 28 Oct 2016 20:28:00 -0000 [thread overview]
Message-ID: <87h97wnrpu.fsf@totoro.br.ibm.com> (raw)
In-Reply-To: <1477328930.7146.81.camel@localhost.localdomain>
Torvald Riegel <triegel@redhat.com> writes:
> On Fri, 2016-10-21 at 19:06 -0200, Tulio Magno Quites Machado Filho
> wrote:
>> diff --git a/sysdeps/powerpc/nptl/elide.h b/sysdeps/powerpc/nptl/elide.h
>> index 77bd82e..c573981 100644
>> --- a/sysdeps/powerpc/nptl/elide.h
>> +++ b/sysdeps/powerpc/nptl/elide.h
>> @@ -102,6 +102,8 @@ __elide_unlock (int is_lock_free)
>> {
>> if (is_lock_free)
>> {
>> + /* Intentionally crashes when trying to unlock a lock not held by this
>> + thread. */
>
> I'd rather say that this can happen, and is okay (refering to the
> comment in pthread_rwlock_unlock.c). Otherwise, LGTM.
Good point. I'll make this change before pushing it.
Thanks!
--
Tulio Magno
prev parent reply other threads:[~2016-10-28 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 21:06 Tulio Magno Quites Machado Filho
2016-10-24 17:08 ` Torvald Riegel
2016-10-28 20:28 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h97wnrpu.fsf@totoro.br.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).