From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/4] Add INTERNAL_SYSCALL_CALL
Date: Tue, 20 Sep 2016 21:36:00 -0000 [thread overview]
Message-ID: <87h99amey7.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <1474383714-15187-2-git-send-email-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 20 Sep 2016 12:01:51 -0300")
* Adhemerval Zanella:
> +#define __INTERNAL_SYSCALL0(name, err) \
> + INTERNAL_SYSCALL (name, err, 0)
> +#define __INTERNAL_SYSCALL1(name, err, a1) \
> + INTERNAL_SYSCALL (name, err, 1, a1)
> +#define __INTERNAL_SYSCALL2(name, err, a1, a2) \
> + INTERNAL_SYSCALL (name, err, 2, a1, a2)
> +#define __INTERNAL_SYSCALL3(name, err, a1, a2, a3) \
> + INTERNAL_SYSCALL (name, err, 3, a1, a2, a3)
> +#define __INTERNAL_SYSCALL4(name, err, a1, a2, a3, a4) \
> + INTERNAL_SYSCALL (name, err, 4, a1, a2, a3, a4)
> +#define __INTERNAL_SYSCALL5(name, err, a1, a2, a3, a4, a5) \
> + INTERNAL_SYSCALL (name, err, 5, a1, a2, a3, a4, a5)
> +#define __INTERNAL_SYSCALL6(name, err, a1, a2, a3, a4, a5, a6) \
> + INTERNAL_SYSCALL (name, err, 6, a1, a2, a3, a4, a5, a6)
> +#define __INTERNAL_SYSCALL7(name, err, a1, a2, a3, a4, a5, a6, a7) \
> + INTERNAL_SYSCALL (name, err, 7, a1, a2, a3, a4, a5, a6, a7)
It's not immediately obvious why these definitions are needed.
> +#define __INTERNAL_SYSCALL_NARGS_X(a, b, c, d, e, f, g, h, n, ...) n
> +#define __INTERNAL_SYSCALL_NARGS(...) \
> + __INTERNAL_SYSCALL_NARGS_X (__VA_ARGS__, 7, 6, 5, 4, 3, 2, 1, 0, )
> +#define __INTERNAL_SYSCALL_CONCAT_X(a, b) a##b
> +#define __INTERNAL_SYSCALL_CONCAT(a, b) __SYSCALL_CONCAT_X (a, b)
I think you can reuse the macros from sysdeps/unix/sysdep.h here.
> +/* Issue a syscall defined by syscall number plus any other argument required.
These comment lines are rather long.
> + Any error will be handled using arch defined macros and errno will be se
> + accordingly.
“will be set”
next prev parent reply other threads:[~2016-09-20 21:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:02 [PATCH 0/4] Linux lseek and {f}truncate syscall consolidation Adhemerval Zanella
2016-09-20 15:02 ` [PATCH 3/4] Consolidate Linux ftruncate implementations Adhemerval Zanella
2016-10-11 14:41 ` Adhemerval Zanella
2016-10-25 17:54 ` Adhemerval Zanella
2016-11-09 13:44 ` Adhemerval Zanella
2016-11-09 15:33 ` Andreas Schwab
2016-11-09 17:24 ` Adhemerval Zanella
2016-09-20 15:02 ` [PATCH 1/4] Add INTERNAL_SYSCALL_CALL Adhemerval Zanella
2016-09-20 21:36 ` Florian Weimer [this message]
2016-09-21 18:00 ` Adhemerval Zanella
2016-09-21 19:22 ` Florian Weimer
2016-09-22 13:43 ` Adhemerval Zanella
2016-09-22 20:34 ` Florian Weimer
2016-09-23 14:16 ` Adhemerval Zanella
2016-09-23 20:39 ` Florian Weimer
2016-09-20 15:02 ` [PATCH 4/4] Consolidate Linux truncate implementations Adhemerval Zanella
2016-09-22 14:25 ` Yury Norov
2016-09-22 14:42 ` Adhemerval Zanella
2016-09-22 15:52 ` Yury Norov
2016-09-22 19:05 ` Adhemerval Zanella
2016-10-25 17:55 ` Adhemerval Zanella
2016-11-09 13:44 ` Adhemerval Zanella
2016-09-20 15:02 ` [PATCH v3 2/4] Consolidate lseek/lseek64/llseek implementations Adhemerval Zanella
2016-10-11 14:40 ` Adhemerval Zanella
2016-10-25 17:54 ` Adhemerval Zanella
2016-11-04 16:23 ` Adhemerval Zanella
2016-11-08 19:02 ` Steve Ellcey
-- strict thread matches above, loose matches on Subject: below --
2016-08-19 14:42 [PATCH 0/4] Linux fallocate, posix_fallocate, and posix_fadvise consolidation Adhemerval Zanella
2016-08-19 14:42 ` [PATCH 1/4] Add INTERNAL_SYSCALL_CALL Adhemerval Zanella
2016-08-22 15:28 ` Yury Norov
2016-08-23 19:16 ` Adhemerval Zanella
2016-08-23 19:20 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h99amey7.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).