From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 4/4] Consolidate Linux truncate implementations
Date: Thu, 22 Sep 2016 14:42:00 -0000 [thread overview]
Message-ID: <330498bd-5430-94eb-f033-73236269be13@linaro.org> (raw)
In-Reply-To: <20160922142442.GA5914@yury-N73SV>
On 22/09/2016 11:24, Yury Norov wrote:
>> +/* Truncate PATH to LENGTH bytes. */
>> int
>> -truncate64 (const char *path, off64_t length)
>> +__truncate64 (const char *path, off64_t length)
>> {
>> - unsigned int low = length & 0xffffffff;
>> - unsigned int high = length >> 32;
>> - int result = INLINE_SYSCALL (truncate64, 3, path,
>> - __LONG_LONG_PAIR (high, low));
>> - return result;
>> + return INLINE_SYSCALL_CALL (truncate64, path,
>> + __ALIGNMENT_ARG SYSCALL_LL64 (length));
>> }
>> +weak_alias (__truncate64, truncate64)
>> +
>> +#ifdef __OFF_T_MATCHES_OFF64_T
>> +weak_alias (__truncate64, truncate);
>> +#endif
>
> It seems you forgot weak_alias (__truncate64, __truncate);
>
I do not think it requires to add __truncate alias since glibc currently
does have internal calls to truncate.
next prev parent reply other threads:[~2016-09-22 14:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:02 [PATCH 0/4] Linux lseek and {f}truncate syscall consolidation Adhemerval Zanella
2016-09-20 15:02 ` [PATCH 3/4] Consolidate Linux ftruncate implementations Adhemerval Zanella
2016-10-11 14:41 ` Adhemerval Zanella
2016-10-25 17:54 ` Adhemerval Zanella
2016-11-09 13:44 ` Adhemerval Zanella
2016-11-09 15:33 ` Andreas Schwab
2016-11-09 17:24 ` Adhemerval Zanella
2016-09-20 15:02 ` [PATCH 1/4] Add INTERNAL_SYSCALL_CALL Adhemerval Zanella
2016-09-20 21:36 ` Florian Weimer
2016-09-21 18:00 ` Adhemerval Zanella
2016-09-21 19:22 ` Florian Weimer
2016-09-22 13:43 ` Adhemerval Zanella
2016-09-22 20:34 ` Florian Weimer
2016-09-23 14:16 ` Adhemerval Zanella
2016-09-23 20:39 ` Florian Weimer
2016-09-20 15:02 ` [PATCH v3 2/4] Consolidate lseek/lseek64/llseek implementations Adhemerval Zanella
2016-10-11 14:40 ` Adhemerval Zanella
2016-10-25 17:54 ` Adhemerval Zanella
2016-11-04 16:23 ` Adhemerval Zanella
2016-11-08 19:02 ` Steve Ellcey
2016-09-20 15:02 ` [PATCH 4/4] Consolidate Linux truncate implementations Adhemerval Zanella
2016-09-22 14:25 ` Yury Norov
2016-09-22 14:42 ` Adhemerval Zanella [this message]
2016-09-22 15:52 ` Yury Norov
2016-09-22 19:05 ` Adhemerval Zanella
2016-10-25 17:55 ` Adhemerval Zanella
2016-11-09 13:44 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=330498bd-5430-94eb-f033-73236269be13@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).