public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v2] Build libsupport.a with exception and asynchronous unwind tables
@ 2023-06-30 22:54 John David Anglin
  2023-07-01  9:41 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: John David Anglin @ 2023-06-30 22:54 UTC (permalink / raw)
  To: libc-alpha; +Cc: carlos

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

The attached change fixes the nptl/tst-cleanupx4 test on hppa. Version
2 uses "CFLAGS-.oS" as suggested.

Okay to install?

Dave
---

support: Build with exceptions and asynchronous unwind tables [BZ #30587]

Changing tst-cleanup4.c to use xread instead of read caused
the nptl/tst-cleanupx4 test to fail.  The routines in libsupport.a
need to be built with exception handling and asynchronous unwind
table support.

v2: Use "CFLAGS-.oS" instead of "override CFLAGS".

diff --git a/support/Makefile b/support/Makefile
index c81e3c928c..917a858bd1 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -239,6 +239,9 @@ CFLAGS-support_paths.c = \
 		-DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" \
 		-DSYSCONFDIR_PATH=\"$(sysconfdir)\"
 
+# Build with exception handling and asynchronous unwind table support.
+CFLAGS-.oS += -fexceptions -fasynchronous-unwind-tables
+
 # In support_timespec_check_in_range we may be passed a very tight
 # range for which we should produce a correct result for expected
 # being within the observed range.  The code uses double internally

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Build libsupport.a with exception and asynchronous unwind tables
  2023-06-30 22:54 [PATCH v2] Build libsupport.a with exception and asynchronous unwind tables John David Anglin
@ 2023-07-01  9:41 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2023-07-01  9:41 UTC (permalink / raw)
  To: John David Anglin; +Cc: libc-alpha, carlos

* John David Anglin:

> The attached change fixes the nptl/tst-cleanupx4 test on hppa. Version
> 2 uses "CFLAGS-.oS" as suggested.
>
> Okay to install?

Yes, please.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-01  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 22:54 [PATCH v2] Build libsupport.a with exception and asynchronous unwind tables John David Anglin
2023-07-01  9:41 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).