From: Florian Weimer <fweimer@redhat.com>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Linux: Support __IPC_64 in sysvctl *ctl command arguments
Date: Thu, 10 Nov 2022 11:39:27 +0100 [thread overview]
Message-ID: <87iljnum8w.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87bkphij87.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Tue, 08 Nov 2022 16:00:56 +0100")
* Florian Weimer via Libc-alpha:
> Old applications pass __IPC_64 as part of the command argument because
> old glibc did not check for unknown commands, and passed through the
> arguments directly to the kernel, without adding __IPC_64.
> Applications need to continue doing that for old glibc compatibility,
> so this commit enables this approach in current glibc.
>
> For msgctl and shmctl, if no translation is required, make
> direct system calls, as we did before the time64 changes. If
> translation is required, mask __IPC_64 from the command argument.
>
> For semctl, the union-in-vararg argument handling means that
> translation is needed on all architectures.
>
> Tested on i686-linux-gnu, powerpc64le-linux-gnu, x86_64-linux-gnu.
> Built with build-many-glibcs.py.
I've filed a bug:
Restore IPC_64 support in sysvipc *ctl functions
<https://sourceware.org/bugzilla/show_bug.cgi?id=29771>
I'm going to reference it in the commit message.
Thanks,
Florian
next prev parent reply other threads:[~2022-11-10 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 15:00 Florian Weimer
2022-11-10 10:39 ` Florian Weimer [this message]
2022-11-10 12:27 ` Adhemerval Zanella Netto
2022-11-10 13:28 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iljnum8w.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).