From: Florian Weimer <fw@deneb.enyo.de>
To: Yu Chien Peter Lin <peterlin@andestech.com>
Cc: <libc-alpha@sourceware.org>, <alankao@andestech.com>,
<ycliang@andestech.com>, <dylan@andestech.com>
Subject: Re: [PATCH] nptl: Convert tst-setuid2 to test-driver
Date: Fri, 30 Sep 2022 11:57:35 +0200 [thread overview]
Message-ID: <87ill5p4kw.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20220930064300.22758-1-peterlin@andestech.com> (Yu Chien Peter Lin's message of "Fri, 30 Sep 2022 14:43:00 +0800")
* Yu Chien Peter Lin:
> diff --git a/support/Makefile b/support/Makefile
> index 551d02941f..4046b12fbd 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -159,6 +159,7 @@ libsupport-routines = \
> xpthread_cancel \
> xpthread_check_return \
> xpthread_cond_wait \
> + xpthread_cond_signal \
> xpthread_create \
> xpthread_detach \
> xpthread_join \
> diff --git a/support/xpthread_cond_signal.c b/support/xpthread_cond_signal.c
> new file mode 100644
> index 0000000000..51d04d2a66
> --- /dev/null
> +++ b/support/xpthread_cond_signal.c
> @@ -0,0 +1,26 @@
> +/* pthread_cond_signal with error checking.
> + Copyright (C) 2016-2022 Free Software Foundation, Inc.
Copyright year should be 2022.
Could you put the support/ changes into a separate patch? Rest looks
good.
prev parent reply other threads:[~2022-09-30 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 6:43 Yu Chien Peter Lin
2022-09-30 9:57 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ill5p4kw.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=alankao@andestech.com \
--cc=dylan@andestech.com \
--cc=libc-alpha@sourceware.org \
--cc=peterlin@andestech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).