public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper.
@ 2023-10-26  3:26 yanzhang.wang
  2023-11-01 14:28 ` Joseph Myers
  2023-11-13 14:56 ` Florian Weimer
  0 siblings, 2 replies; 3+ messages in thread
From: yanzhang.wang @ 2023-10-26  3:26 UTC (permalink / raw)
  To: libc-alpha; +Cc: adhemerval.zanella, yanzhang.wang

From: Yanzhang Wang <yanzhang.wang@intel.com>

If we use cross test with ssh, this test needs to be ran on the remote.
---
 elf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elf/Makefile b/elf/Makefile
index 9176cbf1e3..1065b5c123 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2979,7 +2979,7 @@ $(objpfx)tst-tls-allocation-failure-static-patched: \
 
 $(objpfx)tst-tls-allocation-failure-static-patched.out: \
   $(objpfx)tst-tls-allocation-failure-static-patched
-	$< > $@ 2>&1; echo "status: $$?" >> $@
+	$(test-wrapper) $< > $@ 2>&1; echo "status: $$?" >> $@
 	grep -q '^Fatal glibc error: Cannot allocate TLS block$$' $@ \
 	  && grep -q '^status: 127$$' $@; \
 	  $(evaluate-test)
-- 
2.42.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper.
  2023-10-26  3:26 [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper yanzhang.wang
@ 2023-11-01 14:28 ` Joseph Myers
  2023-11-13 14:56 ` Florian Weimer
  1 sibling, 0 replies; 3+ messages in thread
From: Joseph Myers @ 2023-11-01 14:28 UTC (permalink / raw)
  To: yanzhang.wang; +Cc: libc-alpha, adhemerval.zanella

On Thu, 26 Oct 2023, yanzhang.wang@intel.com wrote:

> From: Yanzhang Wang <yanzhang.wang@intel.com>
> 
> If we use cross test with ssh, this test needs to be ran on the remote.

OK.  (I've seen this same test failure in cross testing.)

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper.
  2023-10-26  3:26 [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper yanzhang.wang
  2023-11-01 14:28 ` Joseph Myers
@ 2023-11-13 14:56 ` Florian Weimer
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2023-11-13 14:56 UTC (permalink / raw)
  To: yanzhang.wang; +Cc: libc-alpha, adhemerval.zanella

* yanzhang wang:

> From: Yanzhang Wang <yanzhang.wang@intel.com>
>
> If we use cross test with ssh, this test needs to be ran on the remote.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 9176cbf1e3..1065b5c123 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -2979,7 +2979,7 @@ $(objpfx)tst-tls-allocation-failure-static-patched: \
>  
>  $(objpfx)tst-tls-allocation-failure-static-patched.out: \
>    $(objpfx)tst-tls-allocation-failure-static-patched
> -	$< > $@ 2>&1; echo "status: $$?" >> $@
> +	$(test-wrapper) $< > $@ 2>&1; echo "status: $$?" >> $@
>  	grep -q '^Fatal glibc error: Cannot allocate TLS block$$' $@ \
>  	  && grep -q '^status: 127$$' $@; \
>  	  $(evaluate-test)

Thanks, applied.

Florian


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-13 14:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26  3:26 [PATCH] test: Run the tst-tls-allocation-failure-static-patched with test-wrapper yanzhang.wang
2023-11-01 14:28 ` Joseph Myers
2023-11-13 14:56 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).