From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org, alx.manpages@gmail.com
Subject: Re: [PATCH v2 1/2] elf: Sort Makefile variables.
Date: Tue, 30 May 2023 14:20:55 +0200 [thread overview]
Message-ID: <87jzwqt3h4.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230530120759.2150593-1-carlos@redhat.com> (Carlos O'Donell's message of "Tue, 30 May 2023 08:07:58 -0400")
* Carlos O'Donell:
> Sort Makefile variables using scrips/sort-makefile-lines.py.
>
> No code generation changes observed in non-test binary artifacts.
> No regressions on x86_64 and i686.
> ---
> elf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 3bfc305d98..c00e2ccfc5 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -274,8 +274,8 @@ tests-static-normal := \
> # tests-static-normal
>
> tests-static-internal := \
> - tst-dl_find_object-static \
> tst-dl-printf-static \
> + tst-dl_find_object-static \
> tst-ptrguard1-static \
> tst-stackguard1-static \
> tst-tls1-static \
Okay,
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
prev parent reply other threads:[~2023-05-30 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:07 Carlos O'Donell
2023-05-30 12:07 ` [PATCH v2 2/2] Add lint-makefiles Makefile linting test Carlos O'Donell
2023-05-30 12:25 ` Florian Weimer
2023-05-30 13:02 ` Carlos O'Donell
2023-05-30 12:20 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzwqt3h4.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alx.manpages@gmail.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).