Re: [PATCH] elf: add test for dl-printf

[Florian Weimer <fweimer@redhat.com>]

* Roy Eldar:

> This patch checks _dl_debug_vdprintf, by passing various inputs to
> _dl_dprintf and comparing the output with invocations of snprintf.
>
> Signed-off-by: Roy Eldar <royeldar0@gmail.com>

Do you have a copyright assignment on file?  If not, Signed-off-by: is
sufficient but we should say …

> diff --git a/elf/tst-dl-printf-static.c b/elf/tst-dl-printf-static.c
> new file mode 100644
> index 0000000000..a31759a006
> --- /dev/null
> +++ b/elf/tst-dl-printf-static.c
> @@ -0,0 +1,75 @@
> +/* Check _dl_debug_vdprintf.
> +   Copyright (C) 2016-2023 Free Software Foundation, Inc.

… “Copyright The GNU Toolchain Authors.” here.

> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +#include <ldsodefs.h>
> +#include <limits.h>
> +#include <stdarg.h>
> +#include <stdio.h>
> +#include <support/check.h>
> +#include <support/xunistd.h>
> +
> +#define BUFSZ 64
> +
> +#define TEST(fmt, ...) do {                                                   \

GNU style puts { and } on their own lines.

> +    char str1[BUFSZ], str2[BUFSZ];                                            \
> +    int len1 = snprintf (str1, BUFSZ, fmt, __VA_ARGS__);                      \
> +    TEST_VERIFY_EXIT (len1 >= 0);                                             \
> +    TEST_VERIFY_EXIT (len1 < BUFSZ);                                          \
> +    _dl_dprintf (fds[1], fmt, __VA_ARGS__);                                   \
> +    ssize_t len2 = read (fds[0], str2, BUFSZ);                                \
> +    TEST_VERIFY_EXIT (len2 >= 0);                                             \
> +    TEST_VERIFY_EXIT (len2 < BUFSZ);                                          \
> +    str2[len2] = '\0';                                                        \
> +    TEST_COMPARE_STRING(str1, str2);                                          \

Missing space after TEST_COMPARE_STRING.

Rest looks good.

Thanks,
Florian