From: Florian Weimer <fweimer@redhat.com>
To: Roy Eldar via Libc-alpha <libc-alpha@sourceware.org>
Cc: Roy Eldar <royeldar0@gmail.com>, carlos@redhat.com
Subject: Re: [PATCH] elf: fix handling of negative numbers in dl-printf
Date: Thu, 25 May 2023 09:46:13 +0200 [thread overview]
Message-ID: <87fs7kq2ey.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230503211641.5742-1-royeldar0@gmail.com> (Roy Eldar via Libc-alpha's message of "Thu, 4 May 2023 00:16:41 +0300")
* Roy Eldar via Libc-alpha:
> _dl_debug_vdprintf is a bare-bones printf implementation; currently
> printing a signed integer (using "%d" format specifier) behaves
> incorrectly when the number is negative, as it just prints the
> corresponding unsigned integer, preceeded by a minus sign.
>
> For example, _dl_printf("%d", -1) would print '-4294967295'.
>
> Signed-off-by: Roy Eldar <royeldar0@gmail.com>
> ---
> elf/dl-printf.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/elf/dl-printf.c b/elf/dl-printf.c
> index e8b9900370..977ac330b6 100644
> --- a/elf/dl-printf.c
> +++ b/elf/dl-printf.c
Please update the copyright staement with
Copyright The GNU Toolchain Authors.
Then I'm going to apply it together with the test.
Thanks,
Florian
next prev parent reply other threads:[~2023-05-25 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 21:16 Roy Eldar
2023-05-08 13:42 ` Florian Weimer
2023-05-08 18:08 ` Roy E
2023-05-24 17:41 ` Roy E
2023-05-15 20:29 ` [PATCH] elf: add test for dl-printf Roy Eldar
2023-05-25 7:44 ` Florian Weimer
2023-05-25 14:41 ` [PATCH v2] " Roy Eldar
2023-05-25 17:10 ` Florian Weimer
2023-05-25 7:46 ` Florian Weimer [this message]
2023-05-25 14:41 ` [PATCH v2] elf: fix handling of negative numbers in dl-printf Roy Eldar
2023-05-25 17:10 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs7kq2ey.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=royeldar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).