From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/4] Initial support for GNU_PROPERTY_1_NEEDED
Date: Mon, 21 Jun 2021 09:06:03 +0200 [thread overview]
Message-ID: <87k0mnn1d0.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210620233620.391576-2-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sun, 20 Jun 2021 16:36:17 -0700")
* H. J. Lu via Libc-alpha:
> diff --git a/elf/elf.h b/elf/elf.h
> index 2a62b98d4a..45b107fdcf 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1310,6 +1310,23 @@ typedef struct
> /* No copy relocation on protected data symbol. */
> #define GNU_PROPERTY_NO_COPY_ON_PROTECTED 2
>
> +/* A 4-byte unsigned integer property: A bit is set if it is set in all
> + relocatable inputs. */
> +#define GNU_PROPERTY_UINT32_AND_LO 0xb0000000
> +#define GNU_PROPERTY_UINT32_AND_HI 0xb0007fff
> +
> +/* A 4-byte unsigned integer property: A bit is set if it is set in any
> + relocatable inputs. */
> +#define GNU_PROPERTY_UINT32_OR_LO 0xb0008000
> +#define GNU_PROPERTY_UINT32_OR_HI 0xb000ffff
> +
> +/* The needed properties by the object file. */
> +#define GNU_PROPERTY_1_NEEDED GNU_PROPERTY_UINT32_OR_LO
> +
> +/* Set if the object file requires canonical function pointers and
> + cannot be used with copy relocation. */
> +#define GNU_PROPERTY_1_NEEDED_SINGLE_GLOBAL_DEFINITION (1U << 0)
> +
> /* Processor-specific semantics, lo */
> #define GNU_PROPERTY_LOPROC 0xc0000000
> /* Processor-specific semantics, hi */
Please add a stable link to the full specification.
I think we need more bits: one bit to indicate the status (in this
patch), and another bit to indicate linker support for this feature.
And perhaps yet another to indicate incompatibility with this feature.
Thanks,
Florian
next prev parent reply other threads:[~2021-06-21 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 23:36 [PATCH 0/4] Implement single global definition marker H.J. Lu
2021-06-20 23:36 ` [PATCH 1/4] Initial support for GNU_PROPERTY_1_NEEDED H.J. Lu
2021-06-21 7:06 ` Florian Weimer [this message]
2021-06-21 12:57 ` H.J. Lu
2021-06-20 23:36 ` [PATCH 2/4] Check -z single-global-definition and -fsingle-global-definition H.J. Lu
2021-06-21 7:31 ` Andreas Schwab
2021-06-21 7:43 ` Florian Weimer
2021-06-21 12:49 ` H.J. Lu
2021-06-20 23:36 ` [PATCH 3/4] Add run-time chesk for single global definition H.J. Lu
2021-06-21 7:16 ` Florian Weimer
2021-06-21 13:20 ` H.J. Lu
2021-06-22 7:12 ` Florian Weimer
2021-06-20 23:36 ` [PATCH 4/4] Update tests for protected data and function symbols H.J. Lu
2021-06-21 7:19 ` Florian Weimer
2021-06-21 12:54 ` H.J. Lu
2021-06-21 12:57 ` Florian Weimer
2021-06-21 13:05 ` H.J. Lu
2021-06-21 20:05 ` [PATCH 0/4] Implement single global definition marker Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0mnn1d0.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).