From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org, Sunil K Pandey <skpgkp2@gmail.com>
Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error"
Date: Sat, 13 Apr 2024 19:50:57 +0200 [thread overview]
Message-ID: <87le5h179a.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOoVx6i-Du7v2_dD=i_s=z0RmMhiuoQrVG7TBLCt6SnDXw@mail.gmail.com> (H. J. Lu's message of "Sat, 13 Apr 2024 08:56:36 -0700")
* H. J. Lu:
>> >> > Could someone proficient in x86-64 assembly have a look at my strcmp
>> >> > implementation?
>> >>
>> >> Can you adapt sysdeps/i386/i686/strcmp.S for valgrind?
>> >>
>> >
>> > You can use sysdeps/x86_64/strcmp.S from glibc 2.10:
>>
>> True. It's mostly a licensing matter at this point. The copyright
>> notice is longer than the assemly …
>
> You can hook your strcmp into glibc and run the glibc strcmp test.
> If it passes the test, it is good to go.
Good suggestion. I verified that it runs, and there are no errors.
So I think we have a solution.
Thanks,
Florian
next prev parent reply other threads:[~2024-04-13 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 14:48 Florian Weimer
2024-04-13 14:58 ` H.J. Lu
2024-04-13 15:03 ` Florian Weimer
2024-04-13 15:09 ` H.J. Lu
2024-04-13 15:20 ` Florian Weimer
2024-04-13 15:27 ` H.J. Lu
2024-04-13 15:49 ` H.J. Lu
2024-04-13 15:52 ` Florian Weimer
2024-04-13 15:56 ` H.J. Lu
2024-04-13 17:50 ` Florian Weimer [this message]
2024-04-13 15:21 Florian Weimer
2024-04-13 15:27 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le5h179a.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).