public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: MAHESH BODAPATI <bmahi496@linux.ibm.com>
Cc: MAHESH BODAPATI via Libc-alpha <libc-alpha@sourceware.org>,
	rajis@linux.ibm.com,  Mahesh Bodapati <mahesh.bodapati@ibm.com>
Subject: Re: [PATCH] powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble
Date: Mon, 15 May 2023 21:26:03 +0200	[thread overview]
Message-ID: <87lehp75x0.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <eca18871-a4c9-2688-5d36-3c376e3894d5@linux.ibm.com> (MAHESH BODAPATI's message of "Mon, 15 May 2023 23:33:13 +0530")

* MAHESH BODAPATI:

> On 15/05/23 6:39 pm, Florian Weimer wrote:
>> * MAHESH BODAPATI via Libc-alpha:
>>
>>> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
>>>
>>> Removed -mabi=ieeelongdouble on failing tests. It resolves the error.
>>> error: ‘-mabi=ieeelongdouble’ requires ‘-mlong-double-128’
>> I think this is only need if GCC defaults to -mabi=ieeelongdouble, and
>> GCC 10 is not ready for that for different reasons?
>
> Yes,these tests are under "sysdeps/ieee754/ldbl-opt" and ieee754
> defaults to -mabi=ieeelongdouble and the
>
> CFLAGS were appended with -mlong-double-64 in commit
> dee2bea048b688b643a9a ,but powerpc gcc (<10)
>
> doesn't support mabi=ieeelongdouble with -mlong-double-64.the support
> has been addedin gcc 12.1 and
>
> it has been back-ported till gcc 10 so we are filtering out the
> -mabi=ieelongdouble to make it work

I think if you backport this stuff to GCC 10, you should also pick up
the commit that fixed GCC.  I believe its commit cb16bc3b5f34733ef9bb
("rs6000: Allow -mlong-double-64 after -mabi={ibm,ieee}longdouble
[PR104208, P R87496]").

Thanks,
Florian


  reply	other threads:[~2023-05-15 19:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 10:22 MAHESH BODAPATI
2023-05-15 13:09 ` Florian Weimer
2023-05-15 18:03   ` MAHESH BODAPATI
2023-05-15 19:26     ` Florian Weimer [this message]
2023-05-16  7:48       ` MAHESH BODAPATI
2023-05-17 22:08         ` Rajalakshmi Srinivasaraghavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lehp75x0.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=bmahi496@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=mahesh.bodapati@ibm.com \
    --cc=rajis@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).