Re: [PATCH] libio: Remove _IO_adjust_column, _IO_adjust_wcolumn, column tracking

[Florian Weimer <fweimer@redhat.com>]

* Florian Weimer:

> Column number tracking was removed from the iostream library during
> C++98 standardization.  It looks like it was never used by
> applications.
>
> On most ports, this is hard symbol removal (no compatibility symbol).
> However, for GLIBC_2.0 ports, it is necessary to keep an
> _IO_adjust_column export because old libstdc++ references this symbol,
> although after the column number is no longer updated by glibc,
> it will not be called anymore.
>
> _IO_adjust_wcolumn was never used in libstdc++. (The wide character
> support was not completed before the switch to C++98 <iostream> and
> its template-based implementation.)
>
> Tested on i686-linux-gnu and x86_64-linux-gnu.  Built with
> build-many-glibcs.py.

And I forgot the NEWS entry:

diff --git a/NEWS b/NEWS
index 4b6d9de2b5..e04aa771f5 100644
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,12 @@ Deprecated and removed features, and other changes affecting compatibility:
   removal of the LD_TRACE_PRELINKING, and LD_USE_LOAD_BIAS, environment
   variables and their functionality in the dynamic loader.
 
+* Column number tracking for streams and the _IO_adjust_column and
+  _IO_adjust_wcolumn functions have been removed.  For targets with the
+  GLIBC_2.0 symbol version, a compatibility definition of
+  _IO_adjust_column is still provided; otherwise the symbols have been
+  removed completely.
+
 Changes to build and runtime requirements:
 
   [Add changes to build and runtime requirements here]

Thanks,
Florian