public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add LE DSCP code point from RFC-8622.
@ 2023-10-13 15:11 Bruno Victal
  2023-10-17 15:44 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: Bruno Victal @ 2023-10-13 15:11 UTC (permalink / raw)
  To: libc-alpha; +Cc: Bruno Victal

Signed-off-by: Bruno Victal <mirai@makinata.eu>
---
 sysdeps/generic/netinet/ip.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sysdeps/generic/netinet/ip.h b/sysdeps/generic/netinet/ip.h
index 6bdb31b65e..20139e97af 100644
--- a/sysdeps/generic/netinet/ip.h
+++ b/sysdeps/generic/netinet/ip.h
@@ -191,6 +191,11 @@ struct ip_timestamp
  */
 #define	IPTOS_DSCP_VA		0xb0
 
+/*
+ * Lower-Effort Per-Hop Behavior DSCP code point from RFC-8622, Section 12.
+ */
+#define	IPTOS_DSCP_LE		0x04
+
 /*
  * In RFC 2474, Section 4.2.2.1, the Class Selector Codepoints subsume
  * the old ToS Precedence values.

base-commit: 69239bd7a216007692470aa9d5f3658024638742
-- 
2.41.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add LE DSCP code point from RFC-8622.
  2023-10-13 15:11 [PATCH] Add LE DSCP code point from RFC-8622 Bruno Victal
@ 2023-10-17 15:44 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2023-10-17 15:44 UTC (permalink / raw)
  To: Bruno Victal; +Cc: libc-alpha

* Bruno Victal:

> Signed-off-by: Bruno Victal <mirai@makinata.eu>
> ---
>  sysdeps/generic/netinet/ip.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sysdeps/generic/netinet/ip.h b/sysdeps/generic/netinet/ip.h
> index 6bdb31b65e..20139e97af 100644
> --- a/sysdeps/generic/netinet/ip.h
> +++ b/sysdeps/generic/netinet/ip.h
> @@ -191,6 +191,11 @@ struct ip_timestamp
>   */
>  #define	IPTOS_DSCP_VA		0xb0
>  
> +/*
> + * Lower-Effort Per-Hop Behavior DSCP code point from RFC-8622, Section 12.
> + */
> +#define	IPTOS_DSCP_LE		0x04
> +
>  /*
>   * In RFC 2474, Section 4.2.2.1, the Class Selector Codepoints subsume
>   * the old ToS Precedence values.
>
> base-commit: 69239bd7a216007692470aa9d5f3658024638742

Looks okay.  The two lowest bits are taken by the ECN indicator, that's
why the value is 4 and not 1 as in the IANA registry.  I will do a test
build just to be sure and push your patch if it passes.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-17 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-13 15:11 [PATCH] Add LE DSCP code point from RFC-8622 Bruno Victal
2023-10-17 15:44 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).