From: Andreas Schwab <schwab@linux-m68k.org>
To: Julian Squires <julian@cipht.net>
Cc: Julian Squires via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] posix: Fix some null deferences in wordexp [BZ #18096]
Date: Sun, 19 Mar 2023 15:16:26 +0100 [thread overview]
Message-ID: <87mt48j079.fsf@igel.home> (raw)
In-Reply-To: <87h6ugx34o.fsf@cipht.net> (Julian Squires's message of "Sun, 19 Mar 2023 11:19:27 -0230")
On Mär 19 2023, Julian Squires wrote:
> The assertion failure mentioned, where seen_hash is set, triggering the
> assertion below, where free_value is set but value is NULL:
>
> if (seen_hash)
> {
> [...]
> if (free_value)
> {
> assert (value != NULL);
> free (value);
> }
That assertion should be removed, it serves no purpose.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-03-19 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 12:59 Julian Squires
2023-03-18 15:10 ` Andreas Schwab
2023-03-19 13:49 ` Julian Squires
2023-03-19 14:16 ` Andreas Schwab [this message]
2023-03-22 16:39 ` [PATCH v2] posix: Fix some crashes " Julian Squires
2023-03-28 13:09 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt48j079.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=julian@cipht.net \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).