From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Cc: DJ Delorie <dj@redhat.com>
Subject: Re: [patch v2] aligned_alloc: conform to C17
Date: Fri, 17 Mar 2023 23:01:26 +0100 [thread overview]
Message-ID: <87mt4bt4uh.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <xnjzzf2oc3.fsf@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Fri, 17 Mar 2023 15:02:36 -0400")
* DJ Delorie via Libc-alpha:
> diff --git a/malloc/Versions b/malloc/Versions
> index c763395c6d..28f41a94f3 100644
> --- a/malloc/Versions
> +++ b/malloc/Versions
> @@ -67,6 +67,9 @@ libc {
> GLIBC_2.33 {
> mallinfo2;
> }
> + GLIBC_2.38 {
> + __libc_aligned_alloc;
> + }
> GLIBC_PRIVATE {
> # Internal startup hook for libpthread.
> __libc_malloc_pthread_startup;
Why do we need to export the __libc_aligned_alloc symbol? That doesn't
seem to be right. We should simply change the behavior of the existing
aligned_alloc symbol.
If you do not want to change behavior for existing binaries (why?), you
should still export a new aligned_alloc@@GLIBC_2.38 symbol (no __libc_
prefix).
(Manpage Cc: dropped.)
Thanks,
Florian
next prev parent reply other threads:[~2023-03-17 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 19:02 DJ Delorie
2023-03-17 21:10 ` Alejandro Colomar
2023-03-17 21:15 ` DJ Delorie
2023-03-17 21:18 ` Alejandro Colomar
2023-03-17 22:01 ` Florian Weimer [this message]
2023-03-17 22:10 ` DJ Delorie
2023-03-17 22:40 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt4bt4uh.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).