From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v2 2/3] Linux: Implement a useful version of _startup_fatal
Date: Wed, 04 May 2022 19:08:35 +0200 [thread overview]
Message-ID: <87mtfxp6ng.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87r159p6sn.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Wed, 04 May 2022 19:05:28 +0200")
* Florian Weimer:
> * Adhemerval Zanella:
>
>> On 04/05/2022 13:48, Florian Weimer wrote:
>>> diff --git a/sysdeps/unix/sysv/linux/startup.h b/sysdeps/unix/sysv/linux/startup.h
>>> new file mode 100644
>>> index 0000000000..a5de941759
>>> --- /dev/null
>>> +++ b/sysdeps/unix/sysv/linux/startup.h
>>> @@ -0,0 +1,38 @@
>>> +/* Linux definitions of functions used by static libc main startup.
>>> + Copyright (C) 2017-2022 Free Software Foundation, Inc.
>>> + This file is part of the GNU C Library.
>>> +
>>> + The GNU C Library is free software; you can redistribute it and/or
>>> + modify it under the terms of the GNU Lesser General Public
>>> + License as published by the Free Software Foundation; either
>>> + version 2.1 of the License, or (at your option) any later version.
>>> +
>>> + The GNU C Library is distributed in the hope that it will be useful,
>>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>> + Lesser General Public License for more details.
>>> +
>>> + You should have received a copy of the GNU Lesser General Public
>>> + License along with the GNU C Library; if not, see
>>> + <https://www.gnu.org/licenses/>. */
>>> +
>>> +#ifdef SHARED
>>> +# include_next <startup.h>
>>> +#else
>>> +# include <sysdep.h>
>>> +
>>> +/* Avoid a run-time invocation of strlen. */
>>> +#define _startup_fatal(message) \
>>> + do \
>>> + { \
>>> + size_t message_length = __builtin_strlen (message); \
>>
>> Shoudn't we use double underscore name to avoid clash with local
>> variables?
>
> I think it's a problem only if message expands to something that uses
> message_length, which is as likely as __message_length. message can't
> be a complex expression anyway because we don't want to call strlen at
> this point.
Never mind, I'm making the change.
Thanks,
Florian
next prev parent reply other threads:[~2022-05-04 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:47 [PATCH v2 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Florian Weimer
2022-05-04 16:48 ` [PATCH v2 2/3] Linux: Implement a useful version of _startup_fatal Florian Weimer
2022-05-04 17:01 ` Adhemerval Zanella
2022-05-04 17:05 ` Florian Weimer
2022-05-04 17:08 ` Florian Weimer [this message]
2022-05-04 18:34 ` H.J. Lu
2022-05-04 19:46 ` Florian Weimer
2022-05-04 20:59 ` Alejandro Colomar
2022-05-05 11:39 ` Florian Weimer
2022-05-04 16:49 ` [PATCH v2 3/3] csu: Implement and use _dl_early_allocate during static startup Florian Weimer
2022-05-04 16:54 ` [PATCH v2 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Adhemerval Zanella
2022-05-04 17:11 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtfxp6ng.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).