From: Florian Weimer <fweimer@redhat.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v2 2/3] Linux: Implement a useful version of _startup_fatal
Date: Thu, 05 May 2022 13:39:16 +0200 [thread overview]
Message-ID: <87ee18nr8b.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <4681247d-2316-6b11-ef43-52b68050c31b@gmail.com> (Alejandro Colomar's message of "Wed, 4 May 2022 22:59:57 +0200")
* Alejandro Colomar:
> Hi Florian,
>
> On 5/4/22 20:34, H.J. Lu via Libc-alpha wrote:
>> On Wed, May 4, 2022 at 9:48 AM Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>> On i386 and ia64, the TCB is not available at this point.
>>> ---
>>> v2: Add ia64 override. On i386, use non-TCB version for non-PIE static, too.
>>> sysdeps/unix/sysv/linux/i386/startup.h | 21 ++------------
>>> sysdeps/unix/sysv/linux/ia64/startup.h | 22 +++++++++++++++
>>> sysdeps/unix/sysv/linux/startup.h | 38 ++++++++++++++++++++++++++
>>> 3 files changed, 63 insertions(+), 18 deletions(-)
>>> create mode 100644 sysdeps/unix/sysv/linux/ia64/startup.h
>>> create mode 100644 sysdeps/unix/sysv/linux/startup.h
>>>
>>> diff --git a/sysdeps/unix/sysv/linux/i386/startup.h b/sysdeps/unix/sysv/linux/i386/startup.h
>>> index 67c9310f3a..85534d09f1 100644
>>> --- a/sysdeps/unix/sysv/linux/i386/startup.h
>>> +++ b/sysdeps/unix/sysv/linux/i386/startup.h
>>> @@ -16,22 +16,7 @@
>>> License along with the GNU C Library; if not, see
>>> <https://www.gnu.org/licenses/>. */
>>>
>>> -#if BUILD_PIE_DEFAULT
>>> -/* Can't use "call *%gs:SYSINFO_OFFSET" during statup in static PIE. */
>>> -# define I386_USE_SYSENTER 0
>>> +/* Can't use "call *%gs:SYSINFO_OFFSET" during statup. */
>
> Typo?
>
> s/statup/startup/
I've fixed this in the two files I changed.
Thanks,
Florian
next prev parent reply other threads:[~2022-05-05 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:47 [PATCH v2 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Florian Weimer
2022-05-04 16:48 ` [PATCH v2 2/3] Linux: Implement a useful version of _startup_fatal Florian Weimer
2022-05-04 17:01 ` Adhemerval Zanella
2022-05-04 17:05 ` Florian Weimer
2022-05-04 17:08 ` Florian Weimer
2022-05-04 18:34 ` H.J. Lu
2022-05-04 19:46 ` Florian Weimer
2022-05-04 20:59 ` Alejandro Colomar
2022-05-05 11:39 ` Florian Weimer [this message]
2022-05-04 16:49 ` [PATCH v2 3/3] csu: Implement and use _dl_early_allocate during static startup Florian Weimer
2022-05-04 16:54 ` [PATCH v2 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Adhemerval Zanella
2022-05-04 17:11 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee18nr8b.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alx.manpages@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).