public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: Re: [PATCH] x86: Disable RTM on Skylake [BZ #27398]
Date: Sat, 27 Mar 2021 20:15:29 +0100	[thread overview]
Message-ID: <87mtuo76i6.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20210327183417.3390361-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sat, 27 Mar 2021 11:34:17 -0700")

* H. J. Lu via Libc-alpha:

> Disable RTM explicitly on Skylake since CPUID may incorrectly report RTM
> feature.
> ---
>  sysdeps/x86/cpu-features.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
> index d7248cbb45..3641a48407 100644
> --- a/sysdeps/x86/cpu-features.c
> +++ b/sysdeps/x86/cpu-features.c
> @@ -518,6 +518,10 @@ init_cpu_features (struct cpu_features *cpu_features)
>  		 with stepping >= 4) to avoid TSX on kernels that weren't
>  		 updated with the latest microcode package (which disables
>  		 broken feature by default).  */
> +	    case 0x8e:
> +	    case 0x9e:
> +	      /* Disable RTM explicitly on Skylake since CPUID may report
> +		 RTM feature incorrectly [BZ #27398].  */
>  	      CPU_FEATURE_UNSET (cpu_features, RTM);
>  	      break;
>  	    }

Won't this affect the server parts as well?  I'm not sure if that's
what our users want.

We need to report the kernel bug properly, it got stalled because we
initially suspected it might be a security bug.

  reply	other threads:[~2021-03-27 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 18:34 H.J. Lu
2021-03-27 19:15 ` Florian Weimer [this message]
2021-03-27 19:57   ` H.J. Lu
2021-03-27 20:02     ` Florian Weimer
2021-03-27 20:13       ` H.J. Lu
2021-03-27 20:16         ` Florian Weimer
2021-03-27 20:16           ` H.J. Lu
2021-03-27 20:16         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtuo76i6.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).