From: Florian Weimer <fweimer@redhat.com>
To: Bruno Haible <bruno@clisp.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] intl: Treat C.UTF-8 locale like C locale, part 2 (BZ# 16621)
Date: Mon, 11 Sep 2023 09:43:02 +0200 [thread overview]
Message-ID: <87o7i92m0p.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230910191739.1083016-1-bruno@clisp.org> (Bruno Haible's message of "Sun, 10 Sep 2023 21:17:39 +0200")
* Bruno Haible:
> The previous commit was incomplete: gettext() still returns a translation
> if the file /usr/share/locale/C/LC_MESSAGES/<domain>.mo exists. This patch
> prohibits the translation also in this case.
>
> * gettext-runtime/intl/dcigettext.c (DCIGETTEXT): Treat C.<encoding> locale
> like the C locale.
> ---
> intl/dcigettext.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/intl/dcigettext.c b/intl/dcigettext.c
> index 27063886d2..fb69bbf94b 100644
> --- a/intl/dcigettext.c
> +++ b/intl/dcigettext.c
> @@ -691,9 +691,10 @@ DCIGETTEXT (const char *domainname, const char *msgid1, const char *msgid2,
> continue;
> }
>
> - /* If the current locale value is C (or POSIX) we don't load a
> - domain. Return the MSGID. */
> - if (strcmp (single_locale, "C") == 0
> + /* If the current locale value is "C" or "C.<encoding>" or "POSIX",
> + we don't load a domain. Return the MSGID. */
> + if ((single_locale[0] == 'C'
> + && (single_locale[1] == '\0' || single_locale[1] == '.'))
> || strcmp (single_locale, "POSIX") == 0)
> break;
I wasn't sure if this is a bug. The implementation does not fallback to
translation, it just uses C as a message catalog. Do you consider this
a problem?
Thanks,
Florian
next prev parent reply other threads:[~2023-09-11 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 19:17 Bruno Haible
2023-09-11 7:43 ` Florian Weimer [this message]
2023-09-12 14:44 ` Bruno Haible
2023-12-12 9:08 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7i92m0p.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=bruno@clisp.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).